tree 15f1a8d83cf28b6b7bdd7d5cf08897f3e845de17
parent 6ac67f18d7f3a0eea728c45ea16993bdfb91ea42
author Danny Tuppeny <danny@tuppeny.com> 1701449311 +0000
committer GitHub <noreply@github.com> 1701449311 -0800
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJlag5fCRBK7hj4Ov3rIwAAI6kIAAVo5bAwmYCB6EhaCZnTMVS8
 iPs2EQs7EtyHDQ+OGsjL1LRKiqgAocVg/p5M7LVlStUb1QwSFv6YTNRCJkoxfhIC
 T9XTjxC6dtUU6TKGuLQy4PbxDoVMGhfLi6O20qBpGCojG5qB5QVyXCC/KRgc2t+7
 FZDcH3oNkNEelhMIaE0Q8DdGDoD5F84TSjsgWVIOPB4guabbDPECWs9bzeCWYwKN
 SqQ/GmgERbpZDsPk+k6zt46ntE/0Kr+K2BPU5Ok6R8E4wwSvfqj3AkgUZMu1RdfA
 7bTK0wUlcaw5YYwK2KWUpqxfC6x2iarUJ9wwd2CAHTfzmtU0fJW6BleLsvlQsQI=
 =KPoQ
 -----END PGP SIGNATURE-----
 

Fix PollingFileWatcher.ready for files that don't exist (#157)

There were a few issues here:

- FileWatcher.ready never fired for files that don't exist because of logic inside FileWatcher existing early if the modification time was `null`
- The test I recently added trying to catch this was incorrectly passing because the mock timestamp code was set so that files that had not been created would return a 0-mtime whereas in the real implementation they return `null`

So this change

a) updates the mock to return `null` for uncreated files (to match the real implementation) which breaks a bunch of tests

b) fixes those tests by updating FileWatcher._poll() to handle `null` mtime separately from being the first poll.