Merge pull request dart-lang/pool#56 from dart-lang/devoncarew-patch-1
populate the pubspec repository field; migrate to package:lints
diff --git a/pkgs/pool/.github/workflows/ci.yml b/pkgs/pool/.github/workflows/ci.yml
index 9a455e7..76d5352 100644
--- a/pkgs/pool/.github/workflows/ci.yml
+++ b/pkgs/pool/.github/workflows/ci.yml
@@ -47,7 +47,7 @@
matrix:
# Add macos-latest and/or windows-latest if relevant for this package.
os: [ubuntu-latest]
- sdk: [2.12.0, dev]
+ sdk: [2.15.0, dev]
steps:
- uses: actions/checkout@v2
- uses: dart-lang/setup-dart@v1.0
diff --git a/pkgs/pool/CHANGELOG.md b/pkgs/pool/CHANGELOG.md
index 9e0a5a5..c9694dd 100644
--- a/pkgs/pool/CHANGELOG.md
+++ b/pkgs/pool/CHANGELOG.md
@@ -1,3 +1,8 @@
+## 1.5.1-dev
+
+* Switch to using `package:lints` for analysis.
+* Populate the pubspec `repository` field.
+
## 1.5.0
* Stable release for null safety.
diff --git a/pkgs/pool/analysis_options.yaml b/pkgs/pool/analysis_options.yaml
index ae67bc0..4fa4b8d 100644
--- a/pkgs/pool/analysis_options.yaml
+++ b/pkgs/pool/analysis_options.yaml
@@ -1,49 +1,5 @@
-include: package:pedantic/analysis_options.yaml
+include: package:lints/recommended.yaml
analyzer:
strong-mode:
implicit-casts: false
-
-linter:
- rules:
- - avoid_function_literals_in_foreach_calls
- - avoid_renaming_method_parameters
- - avoid_returning_null
- - avoid_returning_null_for_future
- - avoid_unused_constructor_parameters
- - await_only_futures
- - camel_case_types
- - cancel_subscriptions
- - comment_references
- - constant_identifier_names
- - control_flow_in_finally
- - directives_ordering
- - empty_statements
- - hash_and_equals
- - implementation_imports
- - invariant_booleans
- - iterable_contains_unrelated_type
- - list_remove_unrelated_type
- - literal_only_boolean_expressions
- - no_adjacent_strings_in_list
- - non_constant_identifier_names
- - only_throw_errors
- - overridden_fields
- - package_api_docs
- - package_names
- - package_prefixed_library_names
- - prefer_const_constructors
- - prefer_initializing_formals
- - prefer_interpolation_to_compose_strings
- - prefer_typing_uninitialized_variables
- - recursive_getters
- - slash_for_doc_comments
- - test_types_in_equals
- - throw_in_finally
- - unnecessary_await_in_return
- - unnecessary_brace_in_string_interps
- - unnecessary_getters_setters
- - unnecessary_lambdas
- - unnecessary_null_aware_assignments
- - unnecessary_parenthesis
- - unnecessary_statements
diff --git a/pkgs/pool/pubspec.yaml b/pkgs/pool/pubspec.yaml
index 421baf5..26ca100 100644
--- a/pkgs/pool/pubspec.yaml
+++ b/pkgs/pool/pubspec.yaml
@@ -1,19 +1,18 @@
name: pool
-version: 1.5.0
-
+version: 1.5.1-dev
description: >-
Manage a finite pool of resources.
Useful for controlling concurrent file system or network requests.
-homepage: https://github.com/dart-lang/pool
+repository: https://github.com/dart-lang/pool
environment:
- sdk: ">=2.12.0-0 <3.0.0"
+ sdk: ">=2.12.0 <3.0.0"
dependencies:
async: ^2.5.0
stack_trace: ^1.10.0
dev_dependencies:
- fake_async: ^1.2.0-nullsafety
- pedantic: ^1.10.0-nullsafety
- test: ^1.16.0-nullsafety
+ fake_async: ^1.2.0
+ lints: ^1.0.0
+ test: ^1.16.0
diff --git a/pkgs/pool/test/pool_test.dart b/pkgs/pool/test/pool_test.dart
index 20e92d5..2dd90f4 100644
--- a/pkgs/pool/test/pool_test.dart
+++ b/pkgs/pool/test/pool_test.dart
@@ -5,7 +5,6 @@
import 'dart:async';
import 'package:fake_async/fake_async.dart';
-import 'package:pedantic/pedantic.dart';
import 'package:pool/pool.dart';
import 'package:stack_trace/stack_trace.dart';
import 'package:test/test.dart';