remove analyzer warnings
add code review settings
R=nweiz@google.com
Review URL: https://codereview.chromium.org//1109053002
diff --git a/pkgs/pub_semver/codereview.settings b/pkgs/pub_semver/codereview.settings
new file mode 100644
index 0000000..94ddf0e
--- /dev/null
+++ b/pkgs/pub_semver/codereview.settings
@@ -0,0 +1,3 @@
+CODE_REVIEW_SERVER: https://codereview.chromium.org/
+VIEW_VC: https://github.com/dart-lang/pub_semver/commit/
+CC_LIST: reviews@dartlang.org
\ No newline at end of file
diff --git a/pkgs/pub_semver/lib/src/version.dart b/pkgs/pub_semver/lib/src/version.dart
index 2821e27..2bf535f 100644
--- a/pkgs/pub_semver/lib/src/version.dart
+++ b/pkgs/pub_semver/lib/src/version.dart
@@ -122,7 +122,7 @@
String build = match[8];
return new Version._(major, minor, patch, preRelease, build, text);
- } on FormatException catch (ex) {
+ } on FormatException {
throw new FormatException('Could not parse "$text".');
}
}
@@ -149,7 +149,7 @@
return text.split('.').map((part) {
try {
return int.parse(part);
- } on FormatException catch (ex) {
+ } on FormatException {
// Not a number.
return part;
}
