misc: enable a few more lints (dart-lang/pubspec_parse#10)
diff --git a/pkgs/pubspec_parse/analysis_options.yaml b/pkgs/pubspec_parse/analysis_options.yaml
index 8521d7b..84a5b8d 100644
--- a/pkgs/pubspec_parse/analysis_options.yaml
+++ b/pkgs/pubspec_parse/analysis_options.yaml
@@ -9,6 +9,7 @@
unused_local_variable: error
linter:
rules:
+ - always_declare_return_types
- annotate_overrides
- avoid_empty_else
- avoid_function_literals_in_foreach_calls
@@ -37,6 +38,7 @@
- library_names
- library_prefixes
- list_remove_unrelated_type
+ - literal_only_boolean_expressions
- no_adjacent_strings_in_list
- no_duplicate_case_values
- non_constant_identifier_names
@@ -51,6 +53,7 @@
- prefer_conditional_assignment
- prefer_const_constructors
- prefer_contains
+ - prefer_equal_for_default_values
- prefer_final_fields
- prefer_initializing_formals
- prefer_interpolation_to_compose_strings
@@ -73,4 +76,5 @@
- unnecessary_statements
- unnecessary_this
- unrelated_type_equality_checks
+ - use_rethrow_when_possible
- valid_regexps
diff --git a/pkgs/pubspec_parse/pubspec.yaml b/pkgs/pubspec_parse/pubspec.yaml
index 0bf1220..e6dbc4c 100644
--- a/pkgs/pubspec_parse/pubspec.yaml
+++ b/pkgs/pubspec_parse/pubspec.yaml
@@ -2,7 +2,7 @@
description: >-
Simple package for parsing pubspec.yaml files with a type-safe API and rich
error reporting.
-version: 0.1.1
+version: 0.1.2-dev
homepage: https://github.com/dart-lang/pubspec_parse
author: Dart Team <misc@dartlang.org>
diff --git a/pkgs/pubspec_parse/test/test_utils.dart b/pkgs/pubspec_parse/test/test_utils.dart
index 7180292..808d7c5 100644
--- a/pkgs/pubspec_parse/test/test_utils.dart
+++ b/pkgs/pubspec_parse/test/test_utils.dart
@@ -49,7 +49,7 @@
}
}
-Pubspec parse(Object content, {bool quietOnError: false}) {
+Pubspec parse(Object content, {bool quietOnError = false}) {
quietOnError ??= false;
var encoded = _encodeJson(content);
@@ -91,5 +91,5 @@
: super('`$name`', '`$name`', matcher);
@override
- featureValueOf(covariant T actual) => _feature(actual);
+ Object featureValueOf(covariant T actual) => _feature(actual);
}
