Google Git
Sign in
dart/tools.git/8200dfd3^!/.
commit
8200dfd3eff93399daa9b99e1cfd464bd84115d6
[log] [tgz]
author
Devon Carew <devoncarew@gmail.com>
Tue Jun 14 17:24:08 2022 -0700
committer
Devon Carew <devoncarew@gmail.com>
Tue Jun 14 17:24:08 2022 -0700
tree
00472d4da64c1f0904b1e7168f07a09731229054
parent
d9c473e65e4eec22fd5988998a3b622a214964ef [diff]
add a few more lints

diff --git a/pkgs/json_rpc_2/analysis_options.yaml b/pkgs/json_rpc_2/analysis_options.yaml
index 572dd23..9ec6408 100644
--- a/pkgs/json_rpc_2/analysis_options.yaml
+++ b/pkgs/json_rpc_2/analysis_options.yaml

@@ -1 +1,15 @@
 include: package:lints/recommended.yaml
+
+linter:
+  rules:
+    - always_declare_return_types
+    # - avoid_dynamic_calls
+    - avoid_unused_constructor_parameters
+    - cancel_subscriptions
+    - directives_ordering
+    - omit_local_variable_types
+    - package_api_docs
+    - prefer_single_quotes
+    - test_types_in_equals
+    - throw_in_finally
+    - unawaited_futures

diff --git a/pkgs/json_rpc_2/test/client/client_test.dart b/pkgs/json_rpc_2/test/client/client_test.dart
index e11e3a9..df9c033 100644
--- a/pkgs/json_rpc_2/test/client/client_test.dart
+++ b/pkgs/json_rpc_2/test/client/client_test.dart

@@ -2,9 +2,9 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-import 'package:test/test.dart';
 import 'package:json_rpc_2/error_code.dart' as error_code;
 import 'package:json_rpc_2/json_rpc_2.dart' as json_rpc;
+import 'package:test/test.dart';
 
 import 'utils.dart';
 

diff --git a/pkgs/json_rpc_2/test/client/stream_test.dart b/pkgs/json_rpc_2/test/client/stream_test.dart
index 286afb6..b33778e 100644
--- a/pkgs/json_rpc_2/test/client/stream_test.dart
+++ b/pkgs/json_rpc_2/test/client/stream_test.dart

@@ -4,11 +4,10 @@
 
 import 'dart:async';
 
+import 'package:json_rpc_2/json_rpc_2.dart' as json_rpc;
 import 'package:stream_channel/stream_channel.dart';
 import 'package:test/test.dart';
 
-import 'package:json_rpc_2/json_rpc_2.dart' as json_rpc;
-
 void main() {
   late StreamController responseController;
   late StreamController requestController;

diff --git a/pkgs/json_rpc_2/test/client/utils.dart b/pkgs/json_rpc_2/test/client/utils.dart
index 398c558..45342cf 100644
--- a/pkgs/json_rpc_2/test/client/utils.dart
+++ b/pkgs/json_rpc_2/test/client/utils.dart

@@ -5,11 +5,10 @@
 import 'dart:async';
 import 'dart:convert';
 
+import 'package:json_rpc_2/json_rpc_2.dart' as json_rpc;
 import 'package:stream_channel/stream_channel.dart';
 import 'package:test/test.dart';
 
-import 'package:json_rpc_2/json_rpc_2.dart' as json_rpc;
-
 /// A controller used to test a [json_rpc.Client].
 class ClientController {
   /// The controller for the client's response stream.

diff --git a/pkgs/json_rpc_2/test/peer_test.dart b/pkgs/json_rpc_2/test/peer_test.dart
index 663da9f..4b4c44a 100644
--- a/pkgs/json_rpc_2/test/peer_test.dart
+++ b/pkgs/json_rpc_2/test/peer_test.dart

@@ -5,11 +5,10 @@
 import 'dart:async';
 import 'dart:convert';
 
-import 'package:stream_channel/stream_channel.dart';
-import 'package:test/test.dart';
-
 import 'package:json_rpc_2/error_code.dart' as error_code;
 import 'package:json_rpc_2/json_rpc_2.dart' as json_rpc;
+import 'package:stream_channel/stream_channel.dart';
+import 'package:test/test.dart';
 
 void main() {
   late StreamSink incoming;
@@ -240,6 +239,7 @@
     );
     peer
       ..registerMethod('foo', () => throw exception)
+      // ignore: unawaited_futures
       ..listen();
 
     incomingController.add({'jsonrpc': '2.0', 'method': 'foo'});

diff --git a/pkgs/json_rpc_2/test/server/batch_test.dart b/pkgs/json_rpc_2/test/server/batch_test.dart
index bdf93a7..b8b8fea 100644
--- a/pkgs/json_rpc_2/test/server/batch_test.dart
+++ b/pkgs/json_rpc_2/test/server/batch_test.dart

@@ -2,8 +2,8 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-import 'package:test/test.dart';
 import 'package:json_rpc_2/error_code.dart' as error_code;
+import 'package:test/test.dart';
 
 import 'utils.dart';
 

diff --git a/pkgs/json_rpc_2/test/server/invalid_request_test.dart b/pkgs/json_rpc_2/test/server/invalid_request_test.dart
index 05376dd..4fa4de1 100644
--- a/pkgs/json_rpc_2/test/server/invalid_request_test.dart
+++ b/pkgs/json_rpc_2/test/server/invalid_request_test.dart

@@ -2,8 +2,8 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-import 'package:test/test.dart';
 import 'package:json_rpc_2/error_code.dart' as error_code;
+import 'package:test/test.dart';
 
 import 'utils.dart';
 

diff --git a/pkgs/json_rpc_2/test/server/parameters_test.dart b/pkgs/json_rpc_2/test/server/parameters_test.dart
index aef6713..9ecfb1f 100644
--- a/pkgs/json_rpc_2/test/server/parameters_test.dart
+++ b/pkgs/json_rpc_2/test/server/parameters_test.dart

@@ -2,8 +2,8 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-import 'package:test/test.dart';
 import 'package:json_rpc_2/json_rpc_2.dart' as json_rpc;
+import 'package:test/test.dart';
 
 import 'utils.dart';
 

diff --git a/pkgs/json_rpc_2/test/server/server_test.dart b/pkgs/json_rpc_2/test/server/server_test.dart
index 11ce201..10f2678 100644
--- a/pkgs/json_rpc_2/test/server/server_test.dart
+++ b/pkgs/json_rpc_2/test/server/server_test.dart

@@ -4,9 +4,9 @@
 
 import 'dart:convert';
 
-import 'package:test/test.dart';
 import 'package:json_rpc_2/error_code.dart' as error_code;
 import 'package:json_rpc_2/json_rpc_2.dart' as json_rpc;
+import 'package:test/test.dart';
 
 import 'utils.dart';
 

diff --git a/pkgs/json_rpc_2/test/server/stream_test.dart b/pkgs/json_rpc_2/test/server/stream_test.dart
index a6d6463..2f95150 100644
--- a/pkgs/json_rpc_2/test/server/stream_test.dart
+++ b/pkgs/json_rpc_2/test/server/stream_test.dart

@@ -4,11 +4,10 @@
 
 import 'dart:async';
 
+import 'package:json_rpc_2/json_rpc_2.dart' as json_rpc;
 import 'package:stream_channel/stream_channel.dart';
 import 'package:test/test.dart';
 
-import 'package:json_rpc_2/json_rpc_2.dart' as json_rpc;
-
 void main() {
   late StreamController requestController;
   late StreamController responseController;

diff --git a/pkgs/json_rpc_2/test/server/utils.dart b/pkgs/json_rpc_2/test/server/utils.dart
index 5900d94..481d342 100644
--- a/pkgs/json_rpc_2/test/server/utils.dart
+++ b/pkgs/json_rpc_2/test/server/utils.dart

@@ -5,12 +5,11 @@
 import 'dart:async';
 import 'dart:convert';
 
+import 'package:json_rpc_2/error_code.dart' as error_code;
+import 'package:json_rpc_2/json_rpc_2.dart' as json_rpc;
 import 'package:stream_channel/stream_channel.dart';
 import 'package:test/test.dart';
 
-import 'package:json_rpc_2/json_rpc_2.dart' as json_rpc;
-import 'package:json_rpc_2/error_code.dart' as error_code;
-
 /// A controller used to test a [json_rpc.Server].
 class ServerController {
   /// The controller for the server's request stream.