Fix check for copied directories (#1967)
The current tests have no useful validation and pass even if the methods
under test are empty because they check that a directory is the same as
itself.
Add a directory name argument when creating the test descriptor
directory and use the parent and copy directory name for `_create` and
`_validate` respectively. Add constants for the directory names.
diff --git a/pkgs/io/test/copy_path_test.dart b/pkgs/io/test/copy_path_test.dart
index fd1e9ce..0c72a0b 100644
--- a/pkgs/io/test/copy_path_test.dart
+++ b/pkgs/io/test/copy_path_test.dart
@@ -13,13 +13,13 @@
void main() {
test('should copy a directory (async)', () async {
await _create();
- await copyPath(p.join(d.sandbox, 'parent'), p.join(d.sandbox, 'copy'));
+ await copyPath(p.join(d.sandbox, _parentDir), p.join(d.sandbox, _copyDir));
await _validate();
});
test('should copy a directory (sync)', () async {
await _create();
- copyPathSync(p.join(d.sandbox, 'parent'), p.join(d.sandbox, 'copy'));
+ copyPathSync(p.join(d.sandbox, _parentDir), p.join(d.sandbox, _copyDir));
await _validate();
});
@@ -27,19 +27,22 @@
await _create();
expect(
copyPath(
- p.join(d.sandbox, 'parent'),
- p.join(d.sandbox, 'parent', 'child'),
+ p.join(d.sandbox, _parentDir),
+ p.join(d.sandbox, _parentDir, 'child'),
),
throwsArgumentError,
);
});
}
-d.DirectoryDescriptor _struct() => d.dir('parent', [
+const _parentDir = 'parent';
+const _copyDir = 'copy';
+
+d.DirectoryDescriptor _struct(String dirName) => d.dir(dirName, [
d.dir('child', [
d.file('foo.txt'),
]),
]);
-Future<void> _create() => _struct().create();
-Future<void> _validate() => _struct().validate();
+Future<void> _create() => _struct(_parentDir).create();
+Future<void> _validate() => _struct(_copyDir).validate();
