tree 9792b5180b470ca7e459b8b93321a9bae1e7daa5
parent 09fb067979684dbd0918f664ec4d178975c84283
author Nate Bosch <nbosch@google.com> 1670867089 -0800
committer GitHub <noreply@github.com> 1670867089 -0800
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJjl2iRCRBK7hj4Ov3rIwAADCUIAEXdy5fFgpX6dsNlE8CaYjMP
 xDSR4S5sV2N/V4yeMRaC062Q2iFBcQwwUFMtORsVMmytkJ5U7yFDkZ3vn8v2JpHG
 fYDr9cLhKfNyNwxz8TACRQaJfpXzZ2Ad6+C2ZN1kv7+C3TVb18/5jYmubXQPPOQH
 W8YxceuxSlyugLHK67ZZ/qxtQ3Qn+oaWbmNd178cxNvtdZRP2KA3r1xCrXNl6FJh
 2zhvb79q7n2D9n607qKMS+kOAGJS7VkIjaUzRGZQ+YhbO8fbk8XhApPraYpBa1Rq
 Cby6hsRYRK+Hy6aJq2WjZl+sMlBGgUk9F+gxhS43XaLUM3wtLobYYVvj77fH5xg=
 =KVc3
 -----END PGP SIGNATURE-----
 

Don't ignore outstanding work on failure (#1815)

Fixes #1512

The test invoker tracks the work done by the test, both the callback
bodies and the other work registered with the framework, and in the
typical case waits for it to complete before the test is considered
done.

Previously, any error would immediately ignore all outstanding work. In
the case of an unhandled async error, the test may still be using
resources that will be cleaned up by the tear down.

Some tests that previously would have failed quickly will now result in
a timeout. This should be uncommon, and will only impact tests that
fail anyway.

- Stop ignoring all outstanding work on any error.
- Explicitly ignore outstanding work for a timeout.
- Fix some cases that run tests that do fail and then timeout. These
  tests had been manually incrementing the outstanding callback count
  and relying on the known failure to prevent a timeout. Decrement the
  outstanding callback count after the errors have been delivered.
- More reliably decrement the outstanding work counter in a few
  situations where an exception from a test callback could cause it to
  be missed so it had to be cleaned up by the error handler.
  - Use a try/finally around callbacks which introduce their own
    outstanding work tracking zones.
  - Use a try/catch/rethrow around the body for load suites (the
    platform work including the user `main` method). Using a try/finally
    can cause the runner to be held open waiting for `main` to complete
    after a signal should have stopped tests.