tree 47d295aefc23ba187cc93a92fc4505bfd7002f04
parent 7e7992f9613e08dd6cd2a071384359118978b7fb
author Paul Berry <stereotype441@gmail.com> 1600103276 -0700
committer GitHub <noreply@github.com> 1600103276 -0700
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJfX6NsCRBK7hj4Ov3rIwAAdHIIAFCTksckIWdbVrbMeZAnH+gw
 4arLPF5F8+xGpPs48CdM7iAE7AqATIfYExOrq02S4kWEQh9z+objmNXDvHMrwXLf
 52bUJMp+ak4GowmY9cb9SRDlOv+9uQCP5w5qa+h32mcZnT7cAsyB8zjWJfW+S5Yl
 ZY53hZL8fckkLf2VHFRiBTXbfvjqcpImwOVkVptSUSBIGfcYCg3qQeR8mMl+T5Jc
 yeNKl11dryKziTgsZjJ7z/FPSDSlpLINwy3Kqh3eUQETFZr3+BhdBrMAjwr/a0wg
 IpCKGClCI7c2+Gvi0R429tN1pwlSM8wbmnk20ctl2fGlDuSk8HcMGv5VPaj4Hpc=
 =Yp1i
 -----END PGP SIGNATURE-----
 

Work around flow analysis bug (#59)

Flow analysis currently has a bug preventing for-each loop variables
from being properly promoted in the presence of closures
(https://github.com/dart-lang/sdk/issues/43136); as a result of this
bug the source_span package had two non-null assertions that ought to
have been unnecessary.

I'm preparing a fix for that bug, however if I land it as is, it will
cause the front end to emit errors saying "Operand of null-aware
operation '!' has type '_Highlight' which excludes null"; this in turn
will cause SDK bot breakages (since source_span is imported into the
SDK repo).

So, in order to land the fix, we need to first update the source_span
package to work around the bug; this change does that by allocating a
temporary variable (which *is* promoted correctly).

Once the fix for https://github.com/dart-lang/sdk/issues/43136 lands,
I will make a follow-up change that deletes the temporary variable.