tree 3c283526ef321a0efd6f3698a4920f20a3f511cb
parent fe1ce13114bb7318e140587f21ebec4cbb127ef3
author Nate Bosch <nbosch@google.com> 1611765522 -0800
committer GitHub <noreply@github.com> 1611765522 -0800
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJgEZcSCRBK7hj4Ov3rIwAAdHIIAErJwnEwF4ITb5R2ZocbbNVM
 RGM+V/BxhSrNgZjV8GnHMz45Bcg/kfYA+KJlivLZLsu1NVI/dZq59ZckMVR00x+k
 iZrBrdRW2Y2hHBogg0BNpYspBrUVzQowrfHp78FJI9mrlZKwh12L/arU9R5dXJCs
 b7HAHbnOcdgtCvoTUdJ0M6wJPxSvx9iFSO2YUeImQ8sXILugtkJMmCaTR9ygxDHA
 CHBKBJ9BtrlWsMCcOkFgEiZ+i4OIbiYGlXYulDSeJ4Eq7GwT+Vqm8ANI9zEqjrLX
 u9s+PzaFuiPWzWxXStnZX97M55tLxNZBA1kWN34fsNWMdBQANHKy8GYO3Dn8Qls=
 =VlRz
 -----END PGP SIGNATURE-----
 

Ignore protocol header if handler did not specify allowed protocols (#28)

Closes #27

The spec says "if the server does not agree to any of the client's
requested subprotocols, the only acceptable value is null". The mozilla
docs for implementing a web socket server say "The client may close the
connection if it doesn't get the subprotocol it wants."

From this I take it that the safest thing to do is to ignore the
protocols. A server which wants to be more careful can handle the `null`
protocol in whatever way makes sense.

- Add a null check before searching for overlap in protocol.
- Remove the explicit check for `protocols` with 2 argument callback.
- Rename `protocols` to `requestProtocols`.
- Add tests demonstrating new behavior, remove test for ArgumentError.