fix(shelf_static): ignore suffix ranges selecting zero bytes (#541)

Restore the start > end check at the end of the suffix branch in _fileRangeResponse so suffix ranges selecting zero bytes (such as bytes=-0 or any suffix range on a 0-byte file) are ignored and served with 200 OK instead of returning 206 Partial Content with a malformed Content-Range header.

- Add if (start > end) return null; guard to the suffix byte range branch
- Add unit tests for bytes=-0, suffix ranges on 0-byte files, and bytes=-1 boundary
- Update 1.2.0-wip changelog entry

Fixes #540
3 files changed
tree: a598a87a71fafce520321c8cb422ba5f8b1e924e
  1. .github/
  2. pkgs/
  3. tool/
  4. vendor/
  5. .gitignore
  6. .gitmodules
  7. analysis_options.yaml
  8. CONTRIBUTING.md
  9. LICENSE
  10. mono_repo.yaml
  11. README.md
README.md

Build Status

About Shelf

Shelf makes it easy to create and compose web servers and parts of web servers. How?

  • Expose a small set of simple types.
  • Map server logic into a simple function: a single argument for the request, the response is the return value.
  • Trivially mix and match synchronous and asynchronous processing.
  • Flexibility to return a simple string or a byte stream with the same model.

It was inspired by Connect for NodeJS and Rack for Ruby.

See the package:shelf readme for more information.

Packages

PackageDescriptionIssuesVersion
shelfA model for web server middleware that encourages composition and easy reuse.issuespub package
shelf_packages_handlerA shelf handler for serving a packages/ directory.issuespub package
shelf_proxyA shelf handler for proxying HTTP requests to another server.issuespub package
shelf_routerA convenient request router for the shelf web-framework, with support for URL-parameters, nested routers and routers generated from source annotations.issuespub package
shelf_router_generatorA package:build-compatible builder for generating request routers for the shelf web-framework based on source annotations.issuespub package
shelf_staticStatic file server support for the shelf package and ecosystem.issuespub package
shelf_test_handlerA Shelf handler that makes it easy to test HTTP interactions.issuespub package
shelf_web_socketA shelf handler that wires up a listener for every connection.issuespub package
_shelf_complianceHTTP/1.1 compliance and hardening tests.issues(not published)

Publishing automation

For information about our publishing automation and release process, see https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.