)]}'
{
  "commit": "a9178a20fcdaa8758d9d8be40be22fa8ad64da3c",
  "tree": "55fec1e7317cc40e25995440e03850c446ee6e17",
  "parents": [
    "b244c0805d9741510526566d69b5cf0f9eacf303"
  ],
  "author": {
    "name": "Jonas Finnemann Jensen",
    "email": "jonasfj@google.com",
    "time": "Mon Aug 13 12:28:54 2018 +0000"
  },
  "committer": {
    "name": "Jonas Jensen",
    "email": "jonasfj@google.com",
    "time": "Mon Aug 13 12:28:54 2018 +0000"
  },
  "message": "Documented issues with HttpClient.authenticate\n\nRetries following `HttpClient.authenticate` does not include the\noriginal request payload, this is an issue as POST, PUT, PATCH\nrequest can be retried through this mechanism. This patch advices\nof the issue and suggests using `HttpClient.AddCredentials` directly\nor setting the `\u0027authorization\u0027` header manually.\n\nCloses https://github.com/dart-lang/sdk/issues/28012\n\n---\n\nIt is possible that we should use even stronger language. It is not immediately obvious\nto me when the `HttpClient.authenticate` property is useful. But retrying POST, PUT, PATCH\nrequests without sending the body again is problematic.\n\nPerhaps we should print a warning when requests with a payload a retries. Or maybe even\ndeprecate the `HttpClient.authenticate` property. I\u0027m new here so please educate me on\nthe useful use-cases.\n\nChange-Id: Iaddba39c2fbb08fd31dda77bf19b9856bfa947f3\nReviewed-on: https://dart-review.googlesource.com/69161\nReviewed-by: Martin Kustermann \u003ckustermann@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "691f15298e9e7092c8851ad5bbe5809e5543b92d",
      "old_mode": 33188,
      "old_path": "sdk/lib/_http/http.dart",
      "new_id": "29e785b699a897b578a10b7c8c4a843d80b00dc9",
      "new_mode": 33188,
      "new_path": "sdk/lib/_http/http.dart"
    }
  ]
}