)]}'
{
  "commit": "58dc4e476d0aa83aec82151c3689a93e504afaf5",
  "tree": "9fdd5c319c07aa1ffccb41253ed8631b89a4c5b4",
  "parents": [
    "e20189ecf58ef85487273ce07d8fc7c2bf925487"
  ],
  "author": {
    "name": "Samir Jindel",
    "email": "sjindel@google.com",
    "time": "Mon May 28 19:23:16 2018 +0000"
  },
  "committer": {
    "name": "commit-bot@chromium.org",
    "email": "commit-bot@chromium.org",
    "time": "Mon May 28 19:23:16 2018 +0000"
  },
  "message": "Revert \"[vm] Support definition of entry-points via @pragma(\u0027vm.extern\u0027) annotations.\"\n\nThis reverts commit 3e50ea32b5e8ddee3c24c7f1f0fe41e9c929cd4b.\n\nReason for revert: Severe performance regressions on many aot-v2 benchmarks.\n\nOriginal change\u0027s description:\n\u003e [vm] Support definition of entry-points via @pragma(\u0027vm.extern\u0027) annotations.\n\u003e \n\u003e The `@pragma` annotations are evaluated by the constants transformation and\n\u003e visible to TFA and the precompiler, which match on the \"options\" field of the\n\u003e annotation to determine whether to mark the class/procedure as a root.\n\u003e \n\u003e This required enabling the transformation of annotation constants by default.\n\u003e \n\u003e # Test Plan\n\u003e \n\u003e The \"vmservice_io.main\" entry-point is removed from `main.cc` and annotated with\n\u003e `@pragma`. All precompiler tests will crash if \"vmservice_io.main\" is not\n\u003e available at runtime.\n\u003e \n\u003e Debug/release precompiler bots are visible in \"cl-linux\" button.\n\u003e \n\u003e Change-Id: I03c5d6ba7918672ed9905fcaee8dabe675a93a5d\n\u003e Reviewed-on: https://dart-review.googlesource.com/56660\n\u003e Commit-Queue: Samir Jindel \u003csjindel@google.com\u003e\n\u003e Reviewed-by: Vyacheslav Egorov \u003cvegorov@google.com\u003e\n\nTBR\u003dvegorov@google.com,alexmarkov@google.com,sjindel@google.com\n\nChange-Id: I779c17d003659129a4b3fcf284423104948f60e2\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nReviewed-on: https://dart-review.googlesource.com/56820\nReviewed-by: Samir Jindel \u003csjindel@google.com\u003e\nCommit-Queue: Samir Jindel \u003csjindel@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "6eb4d87de7b62be67911a2b5da981f4fc10dc929",
      "old_mode": 33188,
      "old_path": "pkg/kernel/binary.md",
      "new_id": "13b28bf9611f0222841a95eecf45549a27a50e91",
      "new_mode": 33188,
      "new_path": "pkg/kernel/binary.md"
    },
    {
      "type": "modify",
      "old_id": "de05b25bedcb4a80ac83ffac0e1b219a5401b369",
      "old_mode": 33188,
      "old_path": "pkg/kernel/lib/core_types.dart",
      "new_id": "e0fe377b75036f4f9323d23ec806e074c88043a1",
      "new_mode": 33188,
      "new_path": "pkg/kernel/lib/core_types.dart"
    },
    {
      "type": "modify",
      "old_id": "72a6607f66794c966c8724292617a11d386723ef",
      "old_mode": 33188,
      "old_path": "pkg/vm/lib/kernel_front_end.dart",
      "new_id": "332017e3285379cbc3a961583b240e7435652991",
      "new_mode": 33188,
      "new_path": "pkg/vm/lib/kernel_front_end.dart"
    },
    {
      "type": "modify",
      "old_id": "4c6eff14bc3b020e02d19f55b5087a9d63a110ab",
      "old_mode": 33188,
      "old_path": "pkg/vm/lib/transformations/type_flow/analysis.dart",
      "new_id": "40a3e79a6880a3a1b9aca25db4231b00e0bcc731",
      "new_mode": 33188,
      "new_path": "pkg/vm/lib/transformations/type_flow/analysis.dart"
    },
    {
      "type": "modify",
      "old_id": "8e4a1719b648c45ad39898bd0a1d968aa16af891",
      "old_mode": 33188,
      "old_path": "pkg/vm/lib/transformations/type_flow/native_code.dart",
      "new_id": "d3f72d6a9da2080178f49f1d6b789c9c4c5c3222",
      "new_mode": 33188,
      "new_path": "pkg/vm/lib/transformations/type_flow/native_code.dart"
    },
    {
      "type": "modify",
      "old_id": "cfcbec76fef44c76217c9e261dfee5ca1c895053",
      "old_mode": 33188,
      "old_path": "pkg/vm/lib/transformations/type_flow/transformer.dart",
      "new_id": "b3a037ace426a72dae85db45f2782d9042761370",
      "new_mode": 33188,
      "new_path": "pkg/vm/lib/transformations/type_flow/transformer.dart"
    },
    {
      "type": "modify",
      "old_id": "7b8346b111107032c9345fcb0162d167a9d65d97",
      "old_mode": 33188,
      "old_path": "runtime/bin/main.cc",
      "new_id": "d46910b061b36d4a7c169c8d319ead2538184979",
      "new_mode": 33188,
      "new_path": "runtime/bin/main.cc"
    },
    {
      "type": "modify",
      "old_id": "9dc5954632fa67e95752158cee11049238250bbe",
      "old_mode": 33188,
      "old_path": "runtime/bin/vmservice/vmservice_io.dart",
      "new_id": "14f6cb6d0d5b21c3fc4e5e62b64eabfbaaf2850b",
      "new_mode": 33188,
      "new_path": "runtime/bin/vmservice/vmservice_io.dart"
    },
    {
      "type": "modify",
      "old_id": "414b63a6eae0b93cd0179e5ec2dd5b1ef0d4ce0e",
      "old_mode": 33188,
      "old_path": "runtime/vm/compiler/aot/precompiler.cc",
      "new_id": "5b2415a8f6db8a318d12499c34c99851179e07db",
      "new_mode": 33188,
      "new_path": "runtime/vm/compiler/aot/precompiler.cc"
    },
    {
      "type": "modify",
      "old_id": "ccbac6caa9b242bf83c1b468d6f3bb0059223fc6",
      "old_mode": 33188,
      "old_path": "runtime/vm/compiler/aot/precompiler.h",
      "new_id": "93e83260a332996df74cf545e07148eb2a63b913",
      "new_mode": 33188,
      "new_path": "runtime/vm/compiler/aot/precompiler.h"
    },
    {
      "type": "modify",
      "old_id": "fc1797145c3916f7adb57b04fe37abf16e6788cd",
      "old_mode": 33188,
      "old_path": "runtime/vm/compiler/frontend/kernel_binary_flowgraph.cc",
      "new_id": "93d70f3b58b054fb95fdd3d8ec071fada2b517cb",
      "new_mode": 33188,
      "new_path": "runtime/vm/compiler/frontend/kernel_binary_flowgraph.cc"
    },
    {
      "type": "modify",
      "old_id": "cabed58750aac88bc899de44e26d698140a1a847",
      "old_mode": 33188,
      "old_path": "runtime/vm/kernel_loader.cc",
      "new_id": "607c1e9f35289223183507f240a946341b81cb10",
      "new_mode": 33188,
      "new_path": "runtime/vm/kernel_loader.cc"
    },
    {
      "type": "modify",
      "old_id": "b8a70a9636d089a485b16cfafd88c1a5868e4727",
      "old_mode": 33188,
      "old_path": "runtime/vm/kernel_loader.h",
      "new_id": "21f4bb26fec35c1360f513a5acc8dff61d9bc1b7",
      "new_mode": 33188,
      "new_path": "runtime/vm/kernel_loader.h"
    },
    {
      "type": "modify",
      "old_id": "ad5aff352f50b91c4c9b70379097f13cebd64a90",
      "old_mode": 33188,
      "old_path": "runtime/vm/object.cc",
      "new_id": "de61db280a8fe6a13342d37ac3304d550cb1834f",
      "new_mode": 33188,
      "new_path": "runtime/vm/object.cc"
    },
    {
      "type": "modify",
      "old_id": "78e036a00501dee459574c819e7c24c681630341",
      "old_mode": 33188,
      "old_path": "runtime/vm/object.h",
      "new_id": "1d8dc12b74e26be23b89fd7191651904a5ddd36e",
      "new_mode": 33188,
      "new_path": "runtime/vm/object.h"
    },
    {
      "type": "modify",
      "old_id": "e2d676dc2f0339ae52f556267ca59820b493f8b7",
      "old_mode": 33188,
      "old_path": "runtime/vm/object_store.cc",
      "new_id": "2d621109570cb1d6a6bc232ce8d53bbe45432978",
      "new_mode": 33188,
      "new_path": "runtime/vm/object_store.cc"
    },
    {
      "type": "modify",
      "old_id": "5c9e90fb66df4476949c4275cf083664fafc0386",
      "old_mode": 33188,
      "old_path": "runtime/vm/object_store.h",
      "new_id": "891760f74a146a77dc7d45703823a878f408f8f0",
      "new_mode": 33188,
      "new_path": "runtime/vm/object_store.h"
    },
    {
      "type": "modify",
      "old_id": "0226504b92d8fcf429d8a4c0035fa60f6d3a4047",
      "old_mode": 33188,
      "old_path": "runtime/vm/parser.cc",
      "new_id": "ac5cd0887af05c91cebf0579bc2ceada16b50d70",
      "new_mode": 33188,
      "new_path": "runtime/vm/parser.cc"
    },
    {
      "type": "modify",
      "old_id": "ca45d6ceec557edece4d23863b7ca73871b0ea5f",
      "old_mode": 33188,
      "old_path": "runtime/vm/parser.h",
      "new_id": "12d0557be372349c2ebec9fd467ced3fb4e44331",
      "new_mode": 33188,
      "new_path": "runtime/vm/parser.h"
    },
    {
      "type": "modify",
      "old_id": "f220ca3fb11268b5fb7df0a816debb396a7d58ae",
      "old_mode": 33188,
      "old_path": "runtime/vm/symbols.h",
      "new_id": "a68bce58207f05f4a34cae065e588df0390933ed",
      "new_mode": 33188,
      "new_path": "runtime/vm/symbols.h"
    }
  ]
}