| commit | 919d50344a8999a401cc00df01cab14384306a19 | [log] [tgz] |
|---|---|---|
| author | Liam Appelbe <liama@google.com> | Wed Aug 13 19:55:28 2025 -0700 |
| committer | Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Aug 13 19:55:28 2025 -0700 |
| tree | 531cbb7acb3daaf360797ea1700a0d9e6e8a384f | |
| parent | af5e3aaab994dd4ade0592d3676acf65dff7028a [diff] |
[vm] Fix deadlock in NativeCallable.listener Switch all lockers of FfiCallbackMetadata::lock_ in FfiCallbackMetadata from MutexLocker to SafepointMutexLocker. The new test deadlocks on patchset 2, before the fix: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8706690957454603105/+/u/test_results/new_test_failures__logs_ And succeeds on patchset 4, after the fix. I found that switching the MutexLocker in DLRT_GetFfiCallbackMetadata to a SafepointMutexLocker caused other NativeCallable.listener tests to fail, so I've left that one unchanged: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8706685486083640001/+/u/test_results/new_test_failures__logs_ Change-Id: I3e48e05d56806488754751b23db27f208f9d396d Fixes: https://github.com/dart-lang/sdk/issues/61272 TEST=tests/ffi/many_listener_callbacks_test.dart Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/445000 Commit-Queue: Liam Appelbe <liama@google.com> Reviewed-by: Slava Egorov <vegorov@google.com>
Dart is:
Approachable: Develop with a strongly typed programming language that is consistent, concise, and offers modern language features like null safety and patterns.
Portable: Compile to ARM, x64, or RISC-V machine code for mobile, desktop, and backend. Compile to JavaScript or WebAssembly for the web.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app. Diagnose app issues using DevTools.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents in our repo at docs.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.
Future plans for Dart are included in the combined Dart and Flutter roadmap on the Flutter wiki.