| commit | 4b322a398aeecfdf10636b1b757e70ed6400b6b3 | [log] [tgz] |
|---|---|---|
| author | Daco Harkes <dacoharkes@google.com> | Thu Apr 07 07:05:27 2022 +0000 |
| committer | Commit Bot <commit-bot@chromium.org> | Thu Apr 07 07:05:27 2022 +0000 |
| tree | 5e739f93709913a23fc0ccedbd258cc5e68c2888 | |
| parent | 139385c6154d73236a94e2171190904ffbb32845 [diff] |
[vm] `Finalizer` / `NativeFinalizer` fixes 1. Run native finalizers before sending isolate exit message. This way users can rely on the isolate exit message for both (1) no Dart code executing anymore on that isolate _and_ (2) all native finalizers having run. Alternatively, we could opt to not provide this second guarantee and document this. 2. Fix UBSAN error by making SetArgumentTo42's argument a `void*`. 3. Fix bug in debug mode, stop reading tags from forwarding addresses. 4. Small optimization: Don't promote 0 bytes from new to old space. 5. Skip finalizer_isolate_groups_run_gc_test in optcounter mode. In hot reload mode, GC is guaranteed to run. On all other bots GC does not run (nothing happens in the other isolate group). However, in optcounter mode enough happens in the other isolate group to trigger GCs. Alternatively, we could loosen the test to allow either a GC to happen or not. TEST=runtime/tests/vm/dart(_2)/finalizer/* TEST=runtime/tests/vm/dart(_2)/isolates/fast_object_copy_test.dart TEST=runtime/vm/object_test.cc TEST=tests/ffi(_2)/vmspecific_native_finalizer_* Closes: https://github.com/dart-lang/sdk/issues/48740 Closes: https://github.com/dart-lang/sdk/issues/48715 Closes: https://github.com/dart-lang/sdk/issues/48674 Change-Id: I5e260e087aef48524f2214f5b332caeda18f2e37 Cq-Include-Trybots: luci.dart.try:vm-kernel-ubsan-linux-release-x64-try,vm-kernel-precomp-ubsan-linux-release-x64-try,vm-canary-linux-debug-try,vm-kernel-optcounter-threshold-linux-release-x64-try,vm-kernel-optcounter-threshold-linux-release-ia32-try,app-kernel-linux-debug-x64-try,vm-kernel-precomp-linux-debug-x64-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/240043 Reviewed-by: Martin Kustermann <kustermann@google.com> Reviewed-by: Ryan Macnak <rmacnak@google.com> Commit-Queue: Daco Harkes <dacoharkes@google.com>
Dart is:
Optimized for UI: Develop with a programming language specialized around the needs of user interface creation.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app.
Fast on all platforms: Compile to ARM & x64 machine code for mobile, desktop, and backend. Or compile to JavaScript for the web.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.