commit f4180854c71cbec340f66fd1c605dc58f70ea38e
author Sam Rawlins <srawlins@google.com> Sat Oct 02 03:01:37 2021 +0000
committer commit-bot@chromium.org <commit-bot@chromium.org> Sat Oct 02 03:01:37 2021 +0000
tree 48eb2a295f4ce5ec0dce1ddfc524b324ad03940a
parent ea4302d02932e301d0891052a8e9df3592e67ced

Refactor evaluateConstructorCall into a separate class

`ConstantEvaluationEngine.evaluateConstructorCall` was ~350 lines long,
with a few short-circuit returns scattered in various for-loops, and
variables used >100 lines from where they were declared or written to.
Much of the code in ConstantEvaluationEngine was dedicated to evaluating
some special functions like `String.fromEnvironment`, etc.
Moving to a new class, _InstanceCreationEvaluator, allows us to move
several helper methods which were only used by that method, and several
static functions. I also split the method into several single-purpose
helper methods.

Improvements to const instance creation expression evaluation should
be more straightforward with this new code, with more single-purpose
methods.

* Move `checkFromEnvironmentArguments`, `checkSymbolArguments`,
  `evaluateSuperConstructorCall`, `followConstantRedirectionChain`, and
  `isValidPublicSymbol` to the new class.
* ConstantEvaluationEngine is reduced from 800 lines to 300 lines.
* Make `getConstRedirectedConstructor` and `_nullObject` static.
* Refactor `ConstantEvaluationEngine.runtimeTypeMatch` into an extension
  on TypeSystem.
* Rename static strings and regexp to use lower_case.
* Use `var` where possible.
* Use single-quoted strings.


Change-Id: Ie28cb961d04c372836783ab2166b02d8ac67d149
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/215158
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>