Google Git
Sign in
dart / sdk / b1b0a6ce14df5f430f23331a276418eb2cd430ca
commitb1b0a6ce14df5f430f23331a276418eb2cd430ca[log] [tgz]
authorAnna Gringauze <annagrin@google.com>Thu Jan 07 23:55:59 2021 +0000
committercommit-bot@chromium.org <commit-bot@chromium.org>Thu Jan 07 23:55:59 2021 +0000
treeb57c5db93f0faa096fc936fa3d9e2936caba02c2
parentb3bca1821c8fa1dd84012443843bb900aeba61a0 [diff]
Do not add variables to scope that appear after the breakpoint

During expression evaluation, we are collecting  all variables in
all scopes that contain the current breakpoint line, and adding them
as available in current scope, which makes variables declared below
the current breakpoint line declared but undefined in JavaScript.

There is one exception to this seen so far - a variable
declared on the current breakpoint line might appear as not declared
in JavaScript and cause expression evaluation not to work due to
JS compilation errors.

This change fixes the issue by not collecting variables that are
declared on or after the current breakpoint line, making them undeclared
in dart (which also is correct according to dart scoping rules).

Closes: https://github.com/flutter/flutter/issues/72094
Change-Id: I113b69531171e0348d44edb8db6dd08a599c9db3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/177760
Commit-Queue: Anna Gringauze <annagrin@google.com>
Reviewed-by: Mark Zhou <markzipan@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
3 files changed
tree: b57c5db93f0faa096fc936fa3d9e2936caba02c2
  1. .dart_tool/
  2. .github/
  3. benchmarks/
  4. build/
  5. client/
  6. docs/
  7. pkg/
  8. runtime/
  9. samples/
  10. samples-dev/
  11. samples_2/
  12. sdk/
  13. tests/
  14. third_party/
  15. tools/
  16. utils/
  17. .clang-format
  18. .gitattributes
  19. .gitconfig
  20. .gitignore
  21. .gn
  22. .mailmap
  23. .packages
  24. .style.yapf
  25. .vpython
  26. AUTHORS
  27. BUILD.gn
  28. CHANGELOG.md
  29. codereview.settings
  30. CONTRIBUTING.md
  31. DEPS
  32. LICENSE
  33. PATENT_GRANT
  34. PRESUBMIT.py
  35. README.dart-sdk
  36. README.md
  37. sdk_args.gni
  38. WATCHLISTS
README.md

Dart

A client-optimized language for fast apps on any platform

Dart is:

  • Optimized for UI: Develop with a programming language specialized around the needs of user interface creation

  • Productive: Make changes iteratively: use hot reload to see the result instantly in your running app

  • Fast on all platforms: Compile to ARM & x64 machine code for mobile, desktop, and backend. Or compile to JavaScript for the web

Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:

  • Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.

  • Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).

Dart platforms illustration

License & patents

Dart is free and open source.

See LICENSE and PATENT_GRANT.

Using Dart

Visit dart.dev to learn more about the language, tools, getting started, and more.

Browse pub.dev for more packages and libraries contributed by the community and the Dart team.

Building Dart

If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.

There are more documents on our wiki.

Contributing to Dart

The easiest way to contribute to Dart is to file issues.

You can also contribute patches, as described in Contributing.