| commit | fce355b8b0247915d96aecfc300716d4c6cf27df | [log] [tgz] |
|---|---|---|
| author | Alexander Aprelev <aam@google.com> | Thu Dec 17 00:22:13 2020 +0000 |
| committer | commit-bot@chromium.org <commit-bot@chromium.org> | Thu Dec 17 00:22:13 2020 +0000 |
| tree | 2c0c2ac7f227d00678045cfd469fef345d6712d4 | |
| parent | c7bd33106b0be6e3ba2429c308b424334bc3c9dc [diff] |
[vm/fields] Always clone fields when running an optimizing compiler, even when it runs on the mutator thread. Attempts to run class finalizaton on background thread revealed the problem where during optimization(which could run on mutator thread too) we might need to finalize previously unseen class, load annotatons for it, load and set some constant fields. This could result in updating Fields guarded_cid, requires check during installation of newly produced optimized code. Because mutator thread is currently exempt from cloning and validating fields guards, that could result in invalid optimized code installation. This CL ensures that fields are always cloned in optimizing compiler even when it runs on mutator thread. Ability to run multiple optimizing compilers is also needed for dartbug.com/36097. Issue https://github.com/dart-lang/sdk/issues/36097 TEST=existing test suite with ltw isolate groups enabled, https://dart-review.googlesource.com/c/sdk/+/176300 mocked up test(still to be improved). Change-Id: I608f4abff30b468cb9d0ab270221a0ba72c32470 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175341 Commit-Queue: Alexander Aprelev <aam@google.com> Reviewed-by: Alexander Markov <alexmarkov@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com>
Dart is:
Optimized for UI: Develop with a programming language specialized around the needs of user interface creation
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app
Fast on all platforms: Compile to ARM & x64 machine code for mobile, desktop, and backend. Or compile to JavaScript for the web
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, getting started, and more.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.