| commit | 6e6303db703316ba6fb5249cc06b5b6d55724350 | [log] [tgz] |
|---|---|---|
| author | Paul Berry <paulberry@google.com> | Fri Nov 14 16:09:59 2025 -0800 |
| committer | Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Nov 14 16:09:59 2025 -0800 |
| tree | 71fe4e4e661e45988edb6afc39d96bd0d90f57b4 | |
| parent | c523cabf186b6df14248c758cb34836e4346fcfe [diff] |
[stable] Fix diagnostic argument mismatch in constant evaluation. Issue description: users experience crashes in the analyzer, analysis server, or dart fix when the `prefer_const_constructors` lint is enabled. What is the fix: constant evaluation is fixed so that it properly propagates diagnostic arguments; failure to do so would cause a crash when the `prefer_const_constructors` lint tried to speculatively constant-evaluate an expression to see if it could be made constant. Why cherry-pick: - Biggest cause of crashes reported by analyzer instrumentation (https://github.com/dart-lang/sdk/issues/61761). - Reported by customers very soon after stable release (https://github.com/dart-lang/sdk/issues/61953). Risk: fairly low, because: - The fix is quite straightforward: the only lines of code affected are those that clearly failed to properly propagate diagnostic arguments, and the change is quite transparent. - Since landing the fix, a further refactor was landed that re-worked constant evaluation to use the analyzer's new literate API for error reporting, which guarantees statically that diagnostic codes and their arguments are properly matched. This refactor was straightforward and didn't require any further changes to program logic, suggesting that the fix was indeed correct. - Note, however, that the fix was only landed a week ago, so there is some increased risk compared to cherry-picking a change that has had more time to "bake". Issue links: - https://github.com/dart-lang/sdk/issues/61761 - https://github.com/dart-lang/sdk/issues/61953 Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/460201 Change-Id: If69434aa96492c3c64aad8b00b46e3d985437ab9 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/461941 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Paul Berry <paulberry@google.com> Reviewed-by: Nate Biggs <natebiggs@google.com>
Dart is:
Approachable: Develop with a strongly typed programming language that is consistent, concise, and offers modern language features like null safety and patterns.
Portable: Compile to ARM, x64, or RISC-V machine code for mobile, desktop, and backend. Compile to JavaScript or WebAssembly for the web.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app. Diagnose app issues using DevTools.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents in our repo at docs.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.
Future plans for Dart are included in the combined Dart and Flutter roadmap on the Flutter wiki.