commit 59905c43f1a0394394ad5545ee439bcba63dea55
author Nicholas Shahan <nshahan@google.com> Fri Nov 07 16:24:54 2025 -0800
committer Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Nov 07 16:24:54 2025 -0800
tree f97ebb1bc01f451f624834843d6db44f2990fc17
parent b4e0dc2f09f6085cd01be6052a08b2c4d3672bba

[ddc] Avoid passing previous dill for standalone hot restart tests

A hot restart should create a fresh compile and reset the chain of
history for hot reload changes. In the "standalone" test suite
(without the use of the frontend server) this should be achieved by
not passing the previous .dill file when compiling with DDC.

Change-Id: If729e62d3f65fd263d5b40d5dad9a5d4ed0d5839
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/450184
Reviewed-by: Nate Biggs <natebiggs@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>

pkg/dev_compiler/test/hot_reload_suite.dart

diff --git a/pkg/dev_compiler/test/hot_reload_suite.dart b/pkg/dev_compiler/test/hot_reload_suite.dart
index fa2ad64..49d5105 100644
--- a/pkg/dev_compiler/test/hot_reload_suite.dart
+++ b/pkg/dev_compiler/test/hot_reload_suite.dart
@@ -1251,7 +1251,10 @@
         .path;
   }
 
-  List<String> _getDdcArguments(String deltaKernelPath, bool recompile) {
+  List<String> _getDdcArguments(
+    String deltaKernelPath,
+    bool recompileForHotReload,
+  ) {
     return [
       '--modules=ddc',
       '--canary',
@@ -1262,7 +1265,7 @@
       '--multi-root-scheme=$filesystemScheme',
       '--experimental-output-compiled-kernel',
       '--experimental-emit-debug-metadata',
-      if (recompile && acceptedDill != null)
+      if (recompileForHotReload && acceptedDill != null)
         '--reload-last-accepted-kernel=$acceptedDill',
       '-o',
       emittedFilesDir.uri.resolve('out.js').path,
@@ -1295,7 +1298,10 @@
     final deltaKernelPath = _createDeltaKernelPath(generation);
     final response = await controller.doWork(
       WorkRequest(
-        arguments: _getDdcArguments(deltaKernelPath, true),
+        arguments: _getDdcArguments(
+          deltaKernelPath,
+          !test.isHotRestart[generation]!,
+        ),
         inputs: [Input(path: deltaKernelPath)],
       ),
     );