Run flutter-analyze-try bot only if analyzer sources have changed
This bot is a part of CQ and was triggerd on a number of paths including
the whole pkg/. It is not hermetic and can fail due to changes in
flutter/flutter and flutter/packages repositories, which would block
unrelated changes from landing.
As a remedy, flutter-analyze-try bot is now included into CQ only if
pkg/(analyzer|analyzer_cli|_fe_analyzer_shared)/.+ sources are
modified. Other analyzer bots are not affected.
See https://github.com/flutter/flutter/issues/177393 for more context.
Change-Id: I520cf76149561600388b7ea2829cc2def2d6f532
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/457081
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
diff --git a/analyzer.star b/analyzer.star
index d3be83c..68f5700 100644
--- a/analyzer.star
+++ b/analyzer.star
@@ -17,7 +17,7 @@
"flutter-analyze",
category = "analyzer|fa",
channels = ["try"],
- location_filters = paths.to_location_filters(paths.analyzer),
+ location_filters = paths.to_location_filters(paths.analyzer_only),
)
dart.ci_sandbox_builder(
"analyzer-analysis-server-linux",
diff --git a/generated/commit-queue.cfg b/generated/commit-queue.cfg
index f056c68..c686be5 100644
--- a/generated/commit-queue.cfg
+++ b/generated/commit-queue.cfg
@@ -310,12 +310,6 @@
gerrit_host_regexp: ".*"
gerrit_project_regexp: ".*"
gerrit_ref_regexp: ".*"
- path_regexp: "runtime/observatory/.+"
- }
- location_filters {
- gerrit_host_regexp: ".*"
- gerrit_project_regexp: ".*"
- gerrit_ref_regexp: ".*"
path_regexp: "runtime/tests/concurrency/.+"
}
location_filters {
@@ -421,12 +415,6 @@
gerrit_host_regexp: ".*"
gerrit_project_regexp: ".*"
gerrit_ref_regexp: ".*"
- path_regexp: "runtime/observatory/.+"
- }
- location_filters {
- gerrit_host_regexp: ".*"
- gerrit_project_regexp: ".*"
- gerrit_ref_regexp: ".*"
path_regexp: "runtime/tests/concurrency/.+"
}
location_filters {
@@ -2684,12 +2672,6 @@
gerrit_host_regexp: ".*"
gerrit_project_regexp: ".*"
gerrit_ref_regexp: ".*"
- path_regexp: "runtime/observatory/.+"
- }
- location_filters {
- gerrit_host_regexp: ".*"
- gerrit_project_regexp: ".*"
- gerrit_ref_regexp: ".*"
path_regexp: "runtime/tests/concurrency/.+"
}
location_filters {
@@ -2795,12 +2777,6 @@
gerrit_host_regexp: ".*"
gerrit_project_regexp: ".*"
gerrit_ref_regexp: ".*"
- path_regexp: "runtime/observatory/.+"
- }
- location_filters {
- gerrit_host_regexp: ".*"
- gerrit_project_regexp: ".*"
- gerrit_ref_regexp: ".*"
path_regexp: "runtime/tests/concurrency/.+"
}
location_filters {
@@ -4133,109 +4109,7 @@
gerrit_host_regexp: ".*"
gerrit_project_regexp: ".*"
gerrit_ref_regexp: ".*"
- path_regexp: "DEPS"
- }
- location_filters {
- gerrit_host_regexp: ".*"
- gerrit_project_regexp: ".*"
- gerrit_ref_regexp: ".*"
- path_regexp: "build/.+"
- }
- location_filters {
- gerrit_host_regexp: ".*"
- gerrit_project_regexp: ".*"
- gerrit_ref_regexp: ".*"
- path_regexp: "BUILD.gn"
- }
- location_filters {
- gerrit_host_regexp: ".*"
- gerrit_project_regexp: ".*"
- gerrit_ref_regexp: ".*"
- path_regexp: "utils/.*/BUILD.gn"
- }
- location_filters {
- gerrit_host_regexp: ".*"
- gerrit_project_regexp: ".*"
- gerrit_ref_regexp: ".*"
- path_regexp: "sdk_args.gni"
- }
- location_filters {
- gerrit_host_regexp: ".*"
- gerrit_project_regexp: ".*"
- gerrit_ref_regexp: ".*"
- path_regexp: "tools/gn.py"
- }
- location_filters {
- gerrit_host_regexp: ".*"
- gerrit_project_regexp: ".*"
- gerrit_ref_regexp: ".*"
- path_regexp: "tools/build.py"
- }
- location_filters {
- gerrit_host_regexp: ".*"
- gerrit_project_regexp: ".*"
- gerrit_ref_regexp: ".*"
- path_regexp: ".dart_tool/package_config.json"
- }
- location_filters {
- gerrit_host_regexp: ".*"
- gerrit_project_regexp: ".*"
- gerrit_ref_regexp: ".*"
- path_regexp: "tools/generate_package_config.py"
- }
- location_filters {
- gerrit_host_regexp: ".*"
- gerrit_project_regexp: ".*"
- gerrit_ref_regexp: ".*"
- path_regexp: "tools/generate_package_config.dart"
- }
- location_filters {
- gerrit_host_regexp: ".*"
- gerrit_project_regexp: ".*"
- gerrit_ref_regexp: ".*"
- path_regexp: "sdk/lib/[^_].+"
- }
- location_filters {
- gerrit_host_regexp: ".*"
- gerrit_project_regexp: ".*"
- gerrit_ref_regexp: ".*"
- path_regexp: "pkg/(async_helper|expect|smith|status_file|test_runner)/.+"
- }
- location_filters {
- gerrit_host_regexp: ".*"
- gerrit_project_regexp: ".*"
- gerrit_ref_regexp: ".*"
- path_regexp: "tools/bots/test_matrix.json"
- }
- location_filters {
- gerrit_host_regexp: ".*"
- gerrit_project_regexp: ".*"
- gerrit_ref_regexp: ".*"
- path_regexp: "tests/.+"
- }
- location_filters {
- gerrit_host_regexp: ".*"
- gerrit_project_regexp: ".*"
- gerrit_ref_regexp: ".*"
- path_regexp: "pkg/.+"
- }
- location_filters {
- gerrit_host_regexp: ".*"
- gerrit_project_regexp: ".*"
- gerrit_ref_regexp: ".*"
- path_regexp: "runtime/observatory/.+"
- }
- location_filters {
- gerrit_host_regexp: ".*"
- gerrit_project_regexp: ".*"
- gerrit_ref_regexp: ".*"
- path_regexp: "runtime/tests/concurrency/.+"
- }
- location_filters {
- gerrit_host_regexp: ".*"
- gerrit_project_regexp: ".*"
- gerrit_ref_regexp: ".*"
- path_regexp: "runtime/tools/dartfuzz/.+"
+ path_regexp: "pkg/(analyzer|analyzer_cli|_fe_analyzer_shared)/.+"
}
}
builders {
@@ -5453,12 +5327,6 @@
gerrit_host_regexp: ".*"
gerrit_project_regexp: ".*"
gerrit_ref_regexp: ".*"
- path_regexp: "runtime/observatory/.+"
- }
- location_filters {
- gerrit_host_regexp: ".*"
- gerrit_project_regexp: ".*"
- gerrit_ref_regexp: ".*"
path_regexp: "runtime/tests/concurrency/.+"
}
location_filters {
@@ -5564,12 +5432,6 @@
gerrit_host_regexp: ".*"
gerrit_project_regexp: ".*"
gerrit_ref_regexp: ".*"
- path_regexp: "runtime/observatory/.+"
- }
- location_filters {
- gerrit_host_regexp: ".*"
- gerrit_project_regexp: ".*"
- gerrit_ref_regexp: ".*"
path_regexp: "runtime/tests/concurrency/.+"
}
location_filters {
diff --git a/lib/paths.star b/lib/paths.star
index e74bf02..c678e84 100644
--- a/lib/paths.star
+++ b/lib/paths.star
@@ -74,16 +74,14 @@
"pkg/(js|modular_test|sourcemap_testing)/.+",
]
-_ANALYZER_NNBD_PATHS = _STANDARD_PATHS + [
- # analyzer sources
+_ANALYZER_PATHS_ONLY = [
"pkg/(analyzer|analyzer_cli|_fe_analyzer_shared)/.+",
]
_ANALYZER_PATHS = _STANDARD_PATHS + [
# "analyzer" bots analyze everything under pkg
"pkg/.+",
- # "analyzer-analysis-server-linux" bot also analyzes dartfuzz, observatory and iso-stress
- "runtime/observatory/.+",
+ # "analyzer-analysis-server-linux" bot also analyzes dartfuzz and iso-stress
"runtime/tests/concurrency/.+",
"runtime/tools/dartfuzz/.+",
]
@@ -116,7 +114,7 @@
paths = struct(
analyzer = _ANALYZER_PATHS,
- analyzer_nnbd = _ANALYZER_NNBD_PATHS,
+ analyzer_only = _ANALYZER_PATHS_ONLY,
cfe = _CFE_PATHS,
cfe_only = _CFE_PATHS_ONLY,
dart2bytecode = _DART2BYTECODE_PATHS,
