| commit | c0e3e3e0cbcc6a541107367dff965208c7923f17 | [log] [tgz] |
|---|---|---|
| author | Danny Tuppeny <danny@tuppeny.com> | Thu Jul 17 04:00:09 2025 -0700 |
| committer | Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Jul 17 04:00:09 2025 -0700 |
| tree | e0361f4ce83495accdc5c6cdab06be3b6edb19c2 | |
| parent | cb8d9bceb4d96e8e6ef6f6513bced708426e38ab [diff] |
[beta] Revert "[dap] Simplify URI handling in IsolateManager.addBreakpoint" and "[dds/dap] Add/remove breakpoints as required instead of replacing the whole set" This is a cherry-pick of a recent commit that reverted two DAP changes because they resulted in leaking of breakpoints/scripts in the VM during reloads. Issue description: Leaking objects in the VM during hot reloads What is the fix: Revert the changes that triggered this issue Why cherry-pick: To avoid this (newly-introduced) leak Risk: Low, this is a simple revert putting code back to how it was previously for many years Issue Link(s): See discussion in https://docs.google.com/document/d/1eeEHG3EL4D5EbB3YiAO5X2TcCRIciFMSPKL_hFGP0Gk/edit?disco=AAABk-csO5o Original revert CL description: This reverts two commits (in separate patch sets in the CL): - commit 482a7caed773bb8e6655808db4384ac90d76d89b: [dap] Simplify URI handling in IsolateManager.addBreakpoint - commit d0a7ef44595fc7ab2991c391c6cd0609b7688402: [dds/dap] Add/remove breakpoints as required instead of replacing the whole set The first revert is to avoid conflicts while reverting the second, and will be reapplied later (likely after the release branch, since it is not critical to include). The second revert is because this change resulted in leaked Script objects in the VM. There is an additional change (patch set 3) to fix up the changelog/versions so they don't go backwards. Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/440162 Change-Id: Idafb16b4d881cc472e8738e48f8e3dfda097e332 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/440661 Commit-Queue: Slava Egorov <vegorov@google.com> Reviewed-by: Ben Konyi <bkonyi@google.com> Reviewed-by: Slava Egorov <vegorov@google.com>
Dart is:
Approachable: Develop with a strongly typed programming language that is consistent, concise, and offers modern language features like null safety and patterns.
Portable: Compile to ARM, x64, or RISC-V machine code for mobile, desktop, and backend. Compile to JavaScript or WebAssembly for the web.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app. Diagnose app issues using DevTools.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents in our repo at docs.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.
Future plans for Dart are included in the combined Dart and Flutter roadmap on the Flutter wiki.