)]}' { "commit": "feefcf0c9431b9cb0c8a2eddb6ae669d04ded9ce", "tree": "9b2c8ccdcde716994205a0f6f9fe09c3445df7b6", "parents": [ "34742535d61043f0732da51a8791f53a2837a93e" ], "author": { "name": "Jens Johansen", "email": "jensj@google.com", "time": "Mon Mar 23 10:25:23 2020 +0000" }, "committer": { "name": "commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Mon Mar 23 10:25:23 2020 +0000" }, "message": "[kernel/CFE] Simplified toString on (ast) nodes\n\nThis is a bare-bones implementation (and test) for having an explicit\ntoString on all `Node`s.\nThis can then be extended as-needed to better suit our debugging\npurposes. It\u0027s not allowed to leak, though.\n\nChange-Id: I8d3f5a9cd13b292ed7a6bf33762e507286f3fa7d\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/139805\nCommit-Queue: Jens Johansen \u003cjensj@google.com\u003e\nReviewed-by: Johnni Winther \u003cjohnniwinther@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "683a87260fb1741000d8b0fe880a3299927a2414", "old_mode": 33188, "old_path": "pkg/dev_compiler/test/nullable_inference_test.dart", "new_id": "67f259f993abdff36aa730af2d74d185221ec331", "new_mode": 33188, "new_path": "pkg/dev_compiler/test/nullable_inference_test.dart" }, { "type": "modify", "old_id": "7846749e4c664fefcc2bedf7ac32a067877f00df", "old_mode": 33188, "old_path": "pkg/front_end/lib/src/base/instrumentation.dart", "new_id": "a1e24433bf00ca8571dd8c9dde7708d4de8dbc81", "new_mode": 33188, "new_path": "pkg/front_end/lib/src/base/instrumentation.dart" }, { "type": "modify", "old_id": "6c4f9ca9fd4a11ad96b1df0490a39cdcfd57c815", "old_mode": 33188, "old_path": "pkg/front_end/lib/src/fasta/kernel/collections.dart", "new_id": "5f142ad16c7282781552778843aa24964a7f8b1c", "new_mode": 33188, "new_path": "pkg/front_end/lib/src/fasta/kernel/collections.dart" }, { "type": "modify", "old_id": "c1104f7d656e22427fc33079a0c208b6b0f2f499", "old_mode": 33188, "old_path": "pkg/front_end/lib/src/fasta/kernel/forest.dart", "new_id": "51a5f213680c582defd7705441934fe49180f09e", "new_mode": 33188, "new_path": "pkg/front_end/lib/src/fasta/kernel/forest.dart" }, { "type": "modify", "old_id": "36edb1b989970b166f3a2ff4479d12f96852c439", "old_mode": 33188, "old_path": "pkg/front_end/lib/src/fasta/kernel/implicit_type_argument.dart", "new_id": "1f0d6cc7a5d2f8a1a142c1bd3dec91954a3c6303", "new_mode": 33188, "new_path": "pkg/front_end/lib/src/fasta/kernel/implicit_type_argument.dart" }, { "type": "modify", "old_id": "227237773bb1a2f21d63962dd8833d2e06997e53", "old_mode": 33188, "old_path": "pkg/front_end/lib/src/fasta/kernel/internal_ast.dart", "new_id": "6f031d91d4c8caedd9738729ede98cfdfa96993f", "new_mode": 33188, "new_path": "pkg/front_end/lib/src/fasta/kernel/internal_ast.dart" }, { "type": "modify", "old_id": "6b88bcdd9678188b0d2ae98d3116f7110b8dfd88", "old_mode": 33188, "old_path": "pkg/front_end/lib/src/fasta/kernel/redirecting_factory_body.dart", "new_id": "ed0ca4a9314a71ad0543b52d0859cfc2d69c2d80", "new_mode": 33188, "new_path": "pkg/front_end/lib/src/fasta/kernel/redirecting_factory_body.dart" }, { "type": "modify", "old_id": "a632f1ae7e5a7fb62a9862f596e12fa0672884f8", "old_mode": 33188, "old_path": "pkg/front_end/lib/src/fasta/type_inference/type_schema.dart", "new_id": "48410b5c7e89beeaa51d755a503258cca9e7d05e", "new_mode": 33188, "new_path": "pkg/front_end/lib/src/fasta/type_inference/type_schema.dart" }, { "type": "modify", "old_id": "11792bcb31548cfef0428007128f48aac57bd9ac", "old_mode": 33188, "old_path": "pkg/front_end/test/fasta/type_inference/type_schema_elimination_test.dart", "new_id": "d08c6e58af8c13e2ac4eb86b39ffcd60b1d1e5cf", "new_mode": 33188, "new_path": "pkg/front_end/test/fasta/type_inference/type_schema_elimination_test.dart" }, { "type": "modify", "old_id": "2bbde19f0f302cb670de720fe059d6ed39464519", "old_mode": 33188, "old_path": "pkg/front_end/test/spell_checking_list_code.txt", "new_id": "a604ce32fa419a61eb405b691a221bd521f2825e", "new_mode": 33188, "new_path": "pkg/front_end/test/spell_checking_list_code.txt" }, { "type": "modify", "old_id": "153bb13ab586e622bf0e7bef69272e599b00dd0a", "old_mode": 33188, "old_path": "pkg/front_end/testcases/general/mixin_constructors_with_default_values.dart.strong.expect", "new_id": "483d84dde658cff6945e20254829dab0544de4fc", "new_mode": 33188, "new_path": "pkg/front_end/testcases/general/mixin_constructors_with_default_values.dart.strong.expect" }, { "type": "modify", "old_id": "b2dbf88c3da8ccb0bec98d3fdfa3c768f18c3786", "old_mode": 33188, "old_path": "pkg/front_end/testcases/general/mixin_constructors_with_default_values.dart.strong.transformed.expect", "new_id": "fe6627411e55ca0caa9418060fc3ce96029e87bb", "new_mode": 33188, "new_path": "pkg/front_end/testcases/general/mixin_constructors_with_default_values.dart.strong.transformed.expect" }, { "type": "modify", "old_id": "500a9d3aa1b9741f9436bbd482e3cbf0781ab534", "old_mode": 33188, "old_path": "pkg/front_end/testcases/general_nnbd_opt_out/mixin_constructors_with_default_values.dart.strong.expect", "new_id": "37d24799cf1e7fba9ef2f7e96eee1f10a73ebbb2", "new_mode": 33188, "new_path": "pkg/front_end/testcases/general_nnbd_opt_out/mixin_constructors_with_default_values.dart.strong.expect" }, { "type": "modify", "old_id": "9c19e86ea679cf32717efae41c94a077c9de07f3", "old_mode": 33188, "old_path": "pkg/front_end/testcases/general_nnbd_opt_out/mixin_constructors_with_default_values.dart.strong.transformed.expect", "new_id": "a3cedca8c94fe579e4fbbaa959f550115f611a44", "new_mode": 33188, "new_path": "pkg/front_end/testcases/general_nnbd_opt_out/mixin_constructors_with_default_values.dart.strong.transformed.expect" }, { "type": "modify", "old_id": "500a9d3aa1b9741f9436bbd482e3cbf0781ab534", "old_mode": 33188, "old_path": "pkg/front_end/testcases/general_nnbd_opt_out/mixin_constructors_with_default_values.dart.weak.expect", "new_id": "37d24799cf1e7fba9ef2f7e96eee1f10a73ebbb2", "new_mode": 33188, "new_path": "pkg/front_end/testcases/general_nnbd_opt_out/mixin_constructors_with_default_values.dart.weak.expect" }, { "type": "modify", "old_id": "9c19e86ea679cf32717efae41c94a077c9de07f3", "old_mode": 33188, "old_path": "pkg/front_end/testcases/general_nnbd_opt_out/mixin_constructors_with_default_values.dart.weak.transformed.expect", "new_id": "a3cedca8c94fe579e4fbbaa959f550115f611a44", "new_mode": 33188, "new_path": "pkg/front_end/testcases/general_nnbd_opt_out/mixin_constructors_with_default_values.dart.weak.transformed.expect" }, { "type": "modify", "old_id": "927bfe13e5893294f606da6cfc55ef278e6b87e6", "old_mode": 33188, "old_path": "pkg/front_end/testcases/nnbd/constants.dart.strong.expect", "new_id": "0293eeb2a91e6e6fc0cb8103c1da9bfa44a5e4a9", "new_mode": 33188, "new_path": "pkg/front_end/testcases/nnbd/constants.dart.strong.expect" }, { "type": "modify", "old_id": "927bfe13e5893294f606da6cfc55ef278e6b87e6", "old_mode": 33188, "old_path": "pkg/front_end/testcases/nnbd/constants.dart.strong.transformed.expect", "new_id": "0293eeb2a91e6e6fc0cb8103c1da9bfa44a5e4a9", "new_mode": 33188, "new_path": "pkg/front_end/testcases/nnbd/constants.dart.strong.transformed.expect" }, { "type": "modify", "old_id": "f7ac5950bc7ef5a7f3e4080a4c678e298cd1c5e2", "old_mode": 33188, "old_path": "pkg/front_end/testcases/nnbd/constants.dart.weak.expect", "new_id": "d4e1e3f7d3305d5d6f8856292959ba2ea71f8a2a", "new_mode": 33188, "new_path": "pkg/front_end/testcases/nnbd/constants.dart.weak.expect" }, { "type": "modify", "old_id": "f7ac5950bc7ef5a7f3e4080a4c678e298cd1c5e2", "old_mode": 33188, "old_path": "pkg/front_end/testcases/nnbd/constants.dart.weak.transformed.expect", "new_id": "d4e1e3f7d3305d5d6f8856292959ba2ea71f8a2a", "new_mode": 33188, "new_path": "pkg/front_end/testcases/nnbd/constants.dart.weak.transformed.expect" }, { "type": "modify", "old_id": "92e1b4cfb0799e1f894be8fa8f34d83a471a2868", "old_mode": 33188, "old_path": "pkg/kernel/lib/ast.dart", "new_id": "3cce9792535b92fad367647c97ebfbb34dceb24e", "new_mode": 33188, "new_path": "pkg/kernel/lib/ast.dart" }, { "type": "modify", "old_id": "72fb6e714dad289e9b403276a26fe8cbfc42e8b1", "old_mode": 33188, "old_path": "pkg/kernel/lib/text/ast_to_text.dart", "new_id": "e3e2566848c6ae0d4465cff4059c4b0b0ae789d2", "new_mode": 33188, "new_path": "pkg/kernel/lib/text/ast_to_text.dart" }, { "type": "modify", "old_id": "87ed4e9553036dc461fd533a1c55231f172d5ff1", "old_mode": 33188, "old_path": "pkg/kernel/test/metadata_test.dart", "new_id": "a6d285a4e38d5e68c9bd9abfb132b00ef8b0252a", "new_mode": 33188, "new_path": "pkg/kernel/test/metadata_test.dart" }, { "type": "modify", "old_id": "d8c3913ad9020bdde9c901da907682414b6a1960", "old_mode": 33188, "old_path": "pkg/vm/testcases/bytecode/asserts.dart.expect", "new_id": "4149a9376b8f750e275f8d128f1fb8ab0c87d3c7", "new_mode": 33188, "new_path": "pkg/vm/testcases/bytecode/asserts.dart.expect" }, { "type": "modify", "old_id": "558d02ff9701405194f85c71a82aa000ab287337", "old_mode": 33188, "old_path": "pkg/vm/testcases/bytecode/closures.dart.expect", "new_id": "fd792c71d7de5ad98ed8c694f2dccdb118bc200e", "new_mode": 33188, "new_path": "pkg/vm/testcases/bytecode/closures.dart.expect" }, { "type": "modify", "old_id": "4bc3448f5e52cc50e5c965b9b0b4239e64fbb7fe", "old_mode": 33188, "old_path": "pkg/vm/testcases/bytecode/try_blocks.dart.expect", "new_id": "1d0580fb996cdd70a2e4e61ab90ba53aaebe57a2", "new_mode": 33188, "new_path": "pkg/vm/testcases/bytecode/try_blocks.dart.expect" }, { "type": "modify", "old_id": "02d84874e292a56c1241c38f0dd8b094e1df4b79", "old_mode": 33188, "old_path": "pkg/vm/testcases/bytecode/type_ops.dart.expect", "new_id": "1293a71f8ec8f2b6f81e59a16ba84780944a84bf", "new_mode": 33188, "new_path": "pkg/vm/testcases/bytecode/type_ops.dart.expect" }, { "type": "modify", "old_id": "f99332f16deb40261f02bb32edcb10326ebc568c", "old_mode": 33188, "old_path": "pkg/vm/testcases/transformations/type_flow/summary_collector/bool_expressions.dart.expect", "new_id": "80c11a90d41444fbc0b052b7ea679d1ff8ed2f34", "new_mode": 33188, "new_path": "pkg/vm/testcases/transformations/type_flow/summary_collector/bool_expressions.dart.expect" }, { "type": "modify", "old_id": "50d02f9beb9d007d80f747df5c37df85cde00ea4", "old_mode": 33188, "old_path": "pkg/vm/testcases/transformations/type_flow/summary_collector/calls.dart.expect", "new_id": "721f2bd3dd72f3f44edf432adc470ae202062387", "new_mode": 33188, "new_path": "pkg/vm/testcases/transformations/type_flow/summary_collector/calls.dart.expect" }, { "type": "modify", "old_id": "774165944aca3c7623e249af6b43e3b1ab60cd7a", "old_mode": 33188, "old_path": "pkg/vm/testcases/transformations/type_flow/summary_collector/constants.dart.expect", "new_id": "b471e61a033edbe631a60c0d5bcf929aa879b086", "new_mode": 33188, "new_path": "pkg/vm/testcases/transformations/type_flow/summary_collector/constants.dart.expect" }, { "type": "modify", "old_id": "eba938000ac2b459b61c63fc2ff711bbd947f419", "old_mode": 33188, "old_path": "pkg/vm/testcases/transformations/type_flow/summary_collector/control_flow.dart.expect", "new_id": "460c3625c05d60659667695ae93f35265a7c6a6d", "new_mode": 33188, "new_path": "pkg/vm/testcases/transformations/type_flow/summary_collector/control_flow.dart.expect" }, { "type": "modify", "old_id": "2aff27c9ffd1346f951ac64fbdd13e2e612b5348", "old_mode": 33188, "old_path": "pkg/vm/testcases/transformations/type_flow/summary_collector/vars.dart.expect", "new_id": "c6281be8f7d5af5f945ca7e9469c67004ab5d9c8", "new_mode": 33188, "new_path": "pkg/vm/testcases/transformations/type_flow/summary_collector/vars.dart.expect" }, { "type": "modify", "old_id": "fd9dd202d43203b65fb33cec79c700503b6f9ea0", "old_mode": 33188, "old_path": "pkg/vm/testcases/transformations/type_flow/transformer/class_generics_basic.dart.expect", "new_id": "6188f8a659f84c19278d838b6619024ca6b1a407", "new_mode": 33188, "new_path": "pkg/vm/testcases/transformations/type_flow/transformer/class_generics_basic.dart.expect" }, { "type": "modify", "old_id": "8c4940c53ad5cc688d49d3c36d0d392ff661097c", "old_mode": 33188, "old_path": "pkg/vm/testcases/transformations/type_flow/transformer/class_generics_case1.dart.expect", "new_id": "701445ceaaee520d3e000fa866407c4b31cf3356", "new_mode": 33188, "new_path": "pkg/vm/testcases/transformations/type_flow/transformer/class_generics_case1.dart.expect" }, { "type": "modify", "old_id": "5ad5c419f441d630dc663a43ddbbf4e833293d65", "old_mode": 33188, "old_path": "pkg/vm/testcases/transformations/type_flow/transformer/const_prop.dart.expect", "new_id": "9f278403a6be0b43640357d01aa390bedb740627", "new_mode": 33188, "new_path": "pkg/vm/testcases/transformations/type_flow/transformer/const_prop.dart.expect" }, { "type": "modify", "old_id": "2f98a40fb0c1e921e4578a0c417befba474855e3", "old_mode": 33188, "old_path": "pkg/vm/testcases/transformations/type_flow/transformer/dynamic_list_access.dart.expect", "new_id": "c2edab08aec9095060e44ce55cea90186ac284ea", "new_mode": 33188, "new_path": "pkg/vm/testcases/transformations/type_flow/transformer/dynamic_list_access.dart.expect" }, { "type": "modify", "old_id": "be83db06439f86b8b085bbc4e168e422cd424cca", "old_mode": 33188, "old_path": "pkg/vm/testcases/transformations/type_flow/transformer/future.dart.expect", "new_id": "406725b3b17ba2a26534e24c97cf36975b051288", "new_mode": 33188, "new_path": "pkg/vm/testcases/transformations/type_flow/transformer/future.dart.expect" }, { "type": "modify", "old_id": "d7385b23964ccb925c0ebb62b0ae0cd8dbc4de40", "old_mode": 33188, "old_path": "pkg/vm/testcases/transformations/type_flow/transformer/future_or.dart.expect", "new_id": "f97cfd3cb326a0af706b91d229ae6531f9f4a4ca", "new_mode": 33188, "new_path": "pkg/vm/testcases/transformations/type_flow/transformer/future_or.dart.expect" }, { "type": "modify", "old_id": "6d5cf67ec6515e362791467d4dceaabc2d4bccb9", "old_mode": 33188, "old_path": "pkg/vm/testcases/transformations/type_flow/transformer/invalidation_field_initializer.dart.expect", "new_id": "975ada13ef09e13171cc26b5ed055c09590376cc", "new_mode": 33188, "new_path": "pkg/vm/testcases/transformations/type_flow/transformer/invalidation_field_initializer.dart.expect" }, { "type": "modify", "old_id": "95c4d004d7e91a19dbe7e3e793d181546dd28544", "old_mode": 33188, "old_path": "pkg/vm/testcases/transformations/type_flow/transformer/invalidation_new_class1.dart.expect", "new_id": "5685ec8af477a123aee2a4f83971bba81f691c79", "new_mode": 33188, "new_path": "pkg/vm/testcases/transformations/type_flow/transformer/invalidation_new_class1.dart.expect" }, { "type": "modify", "old_id": "614926714bb3def35ae9a908b523a0bed4a3953c", "old_mode": 33188, "old_path": "pkg/vm/testcases/transformations/type_flow/transformer/invalidation_new_class2.dart.expect", "new_id": "1718427db26b4985f7059bc942de5271ab3a4d8d", "new_mode": 33188, "new_path": "pkg/vm/testcases/transformations/type_flow/transformer/invalidation_new_class2.dart.expect" }, { "type": "modify", "old_id": "c86de6e58ee796f8d5d9f852942cd508fc9e3834", "old_mode": 33188, "old_path": "pkg/vm/testcases/transformations/type_flow/transformer/invalidation_new_dynamic_target.dart.expect", "new_id": "9321536ca53a7a4500aaaf4cc4300502b04bf2ae", "new_mode": 33188, "new_path": "pkg/vm/testcases/transformations/type_flow/transformer/invalidation_new_dynamic_target.dart.expect" }, { "type": "modify", "old_id": "6698bb7ae12de87e03a489601f5315d9bb8ea72a", "old_mode": 33188, "old_path": "pkg/vm/testcases/transformations/type_flow/transformer/invalidation_set_field.dart.expect", "new_id": "c4aba2f7c8ad79d1c40901acb404e9a1ad4ada4e", "new_mode": 33188, "new_path": "pkg/vm/testcases/transformations/type_flow/transformer/invalidation_set_field.dart.expect" }, { "type": "modify", "old_id": "9372e70f9c85812721a7225fc98c0c02dbc50a77", "old_mode": 33188, "old_path": "pkg/vm/testcases/transformations/type_flow/transformer/invalidation_set_field2.dart.expect", "new_id": "fdbf579ab9ea85118c785fd6d498eb3f4c9fdc9e", "new_mode": 33188, "new_path": "pkg/vm/testcases/transformations/type_flow/transformer/invalidation_set_field2.dart.expect" }, { "type": "modify", "old_id": "fa129adcd7f11d8d646af5273b53680cf99b778a", "old_mode": 33188, "old_path": "pkg/vm/testcases/transformations/type_flow/transformer/no_such_method.dart.expect", "new_id": "52f7c57f4fd95a1698528c56339adbf64b3b1240", "new_mode": 33188, "new_path": "pkg/vm/testcases/transformations/type_flow/transformer/no_such_method.dart.expect" }, { "type": "modify", "old_id": "0378ccece70753acbb9ab6d3cf5eab9bf776c392", "old_mode": 33188, "old_path": "pkg/vm/testcases/transformations/type_flow/transformer/param_types_before_strong_mode_checks.dart.expect", "new_id": "3a1361a28212392c7b7822e67bbce23a44f80589", "new_mode": 33188, "new_path": "pkg/vm/testcases/transformations/type_flow/transformer/param_types_before_strong_mode_checks.dart.expect" }, { "type": "modify", "old_id": "a7ca2b50bdc76d30ee02afd6cbf56f733cfb84ed", "old_mode": 33188, "old_path": "pkg/vm/testcases/transformations/type_flow/transformer/regress_37455.dart.expect", "new_id": "471befff04869592a2ed1aa564063704a4dd1ed9", "new_mode": 33188, "new_path": "pkg/vm/testcases/transformations/type_flow/transformer/regress_37455.dart.expect" }, { "type": "modify", "old_id": "de1797614a4f13225b139d50c5bfc130b0136d3f", "old_mode": 33188, "old_path": "pkg/vm/testcases/transformations/type_flow/transformer/regress_37719.dart.expect", "new_id": "bb1f31d1fa22119e3965307eb8e8e934730591d5", "new_mode": 33188, "new_path": "pkg/vm/testcases/transformations/type_flow/transformer/regress_37719.dart.expect" }, { "type": "modify", "old_id": "ab1a24ee6631be50782ad2c3f7af5bcc9b1bf7b6", "old_mode": 33188, "old_path": "pkg/vm/testcases/transformations/type_flow/transformer/regress_flutter16182.dart.expect", "new_id": "3b00d52c1da453eeafeaab09806cec57ab91e14b", "new_mode": 33188, "new_path": "pkg/vm/testcases/transformations/type_flow/transformer/regress_flutter16182.dart.expect" }, { "type": "modify", "old_id": "e3c299629938c55ba237feed5afbcee1ad43db7b", "old_mode": 33188, "old_path": "pkg/vm/testcases/transformations/type_flow/transformer/tear_off_dynamic_method.dart.expect", "new_id": "f2aa9f54f576996976f57413c0382ea9645f4dc9", "new_mode": 33188, "new_path": "pkg/vm/testcases/transformations/type_flow/transformer/tear_off_dynamic_method.dart.expect" } ] }