| commit | fe6f87f1370925450b6a8dc1be686bcbd143515b | [log] [tgz] |
|---|---|---|
| author | Paul Berry <paulberry@google.com> | Tue Mar 04 13:00:20 2025 -0800 |
| committer | Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Mar 04 13:00:20 2025 -0800 |
| tree | 09128292d5ef2bd5936d05bdf1114dc0ef7e2935 | |
| parent | 29c24dbe2728ec7f3a2895a51ddb8aa0f2fb7d23 [diff] |
[analyzer] Fix dead code reporting in property access and is/as. The way dead code detection works in the analyzer is that at various ad hoc times during the process of resolution (typically before visiting an expression or statement), the `ResolverVisitor` calls `checkUnreachableNode`, which asks flow analysis whether the current point in execution is reachable, and if it isn't, arranges for an unreachable code warning to be produced. This wasn't working for property extractions, type casts, and type tests because there's no subexpression whose execution follows the subexpression that returns `Never`, so `checkUnreachableNode` wasn't getting called. The fix is simple; just add some calls to `checkUnreachableNode` to cover the RHS of a property access, type cast, or type test. Note that property accesses in the analyzer can be represented either as `PrefixedIdentifier` or `PropertyAccess`, so the property access fix had to be done in two places (and accordingly there are two tests for it). Fixes https://github.com/dart-lang/sdk/issues/60247. Bug: https://github.com/dart-lang/sdk/issues/60247 Change-Id: I49e739784f629b77443ce6d31e67809f48de75be Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/413521 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Paul Berry <paulberry@google.com> Auto-Submit: Paul Berry <paulberry@google.com>
Dart is:
Approachable: Develop with a strongly typed programming language that is consistent, concise, and offers modern language features like null safety and patterns.
Portable: Compile to ARM, x64, or RISC-V machine code for mobile, desktop, and backend. Compile to JavaScript or WebAssembly for the web.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app. Diagnose app issues using DevTools.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents in our repo at docs.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.
Future plans for Dart are included in the combined Dart and Flutter roadmap on the Flutter wiki.