| commit | fa4d761f07361830bf6d6705762342b07e821e64 | [log] [tgz] |
|---|---|---|
| author | Srujan Gaddam <srujzs@google.com> | Thu Mar 06 00:37:24 2025 -0800 |
| committer | Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Mar 06 00:37:24 2025 -0800 |
| tree | e6e9330ca0204865a3a92785dfd27f69a9d902e1 | |
| parent | 33286f9cbb09885f4b40264ecd388a86d1aa436f [diff] |
[ddc] Align error message with VM when reload is rejected https://github.com/flutter/flutter/blob/f3d0f5a2ca422b1d8cbfc1c4d67ae288ce22ee47/packages/flutter_tools/lib/src/run_hot.dart#L1669 The above is emitted when a reload is rejected at runtime in the VM. Since we reject errors at compile-time, we should align the error messages. Change-Id: I6687d3efaf87d1dce1c7d21591039cbb5a447ff1 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/413543 Commit-Queue: Johnni Winther <johnniwinther@google.com> Reviewed-by: Johnni Winther <johnniwinther@google.com> Reviewed-by: Nicholas Shahan <nshahan@google.com> Auto-Submit: Srujan Gaddam <srujzs@google.com>
diff --git a/pkg/dev_compiler/lib/src/command/command.dart b/pkg/dev_compiler/lib/src/command/command.dart index b9d1cb4..4a6fef7 100644 --- a/pkg/dev_compiler/lib/src/command/command.dart +++ b/pkg/dev_compiler/lib/src/command/command.dart
@@ -369,7 +369,7 @@ if (rejectionReasons.isNotEmpty) { throw StateError( 'Hot reload rejected due to:\n${rejectionReasons.join('\n')}\n' - 'Use hot restart instead.'); + 'Try performing a hot restart instead.'); } } var sink = File(reloadDeltaKernel).openWrite();
diff --git a/pkg/frontend_server/lib/src/javascript_bundle.dart b/pkg/frontend_server/lib/src/javascript_bundle.dart index a84a822..b7bb013 100644 --- a/pkg/frontend_server/lib/src/javascript_bundle.dart +++ b/pkg/frontend_server/lib/src/javascript_bundle.dart
@@ -98,7 +98,7 @@ if (errors.isNotEmpty) { throw new Exception(errors.join('/n') + '\nHot reload rejected due to unsupported changes. ' - 'Use hot restart instead.'); + 'Try performing a hot restart instead.'); } } _currentComponent = partialComponent;