commit | 58bb05b7c731329173111e700da0d3143965510c | [log] [tgz] |
---|---|---|
author | Aart Bik <ajcbik@google.com> | Thu Nov 08 20:58:16 2018 +0000 |
committer | William Hesse <whesse@google.com> | Thu Nov 08 22:54:00 2018 +0100 |
tree | c89b32ba7e6e532d95587545cafe0a80cbf364e5 | |
parent | 27e98d56433fd47c2c694cdee6a783032c8854cf [diff] |
Reland "[vm/compiler] Fine tune operator and phi handling." This reverts commit cde479301a81f9fbaec3fb007457a4ec8e5a65a7. Reason for revert: the real underlying bug has been fixed Original change's description: > Revert "[vm/compiler] Fine tune operator and phi handling." > > This reverts commit 4d5b5bb5a6b46ce070437febbc1f2f4c0f6f9656. > > Reason for revert: We are seeing an AOT compiler issue as a result of this change (please see https://github.com/flutter/flutter/issues/23879) > > Original change's description: > > [vm/compiler] Fine tune operator and phi handling. > > > > Rationale: > > Running an extra call specialization pass a bit later > > in the compiler passes stream (after types are propagated) > > recognizes more operators, which execute more efficiently. > > In addition, unboxing phis seems useful on all archs, not > > just 32-bit. These minor tweeks combined improve the prime > > number benchmark 3 fold. > > > > https://github.com/flutter/flutter/issues/19677 > > > > Change-Id: Ib2102ce807c2f0a9f801542e0c4bc6a7673f552b > > Reviewed-on: https://dart-review.googlesource.com/69240 > > Reviewed-by: Vyacheslav Egorov <vegorov@google.com> > > Commit-Queue: Aart Bik <ajcbik@google.com> > > TBR=vegorov@google.com,alexmarkov@google.com,asiva@google.com,ajcbik@google.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Change-Id: I46e420f9355bfc3c4a3f2fb9274f648e8a596d9a > Reviewed-on: https://dart-review.googlesource.com/c/83229 > Reviewed-by: Siva Annamalai <asiva@google.com> > Reviewed-by: Aart Bik <ajcbik@google.com> > Commit-Queue: Siva Annamalai <asiva@google.com> TBR=vegorov@google.com,alexmarkov@google.com,asiva@google.com,ajcbik@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I7f9d892a6225c42810e7be52b6845bfee9cc017d Reviewed-on: https://dart-review.googlesource.com/c/83800 Reviewed-by: Aart Bik <ajcbik@google.com> Reviewed-by: Alexander Markov <alexmarkov@google.com> Commit-Queue: Aart Bik <ajcbik@google.com>
Dart is an open-source, scalable programming language, with robust libraries and runtimes, for building web, server, and mobile apps.
Visit the dartlang.org to learn more about the language, tools, getting started, and more.
Browse pub.dartlang.org for more packages and libraries contributed by the community and the Dart team.
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.