commit f8d1d003c9b7dfbc1c78679c70816507a9bc0f4b
author Regis Crelier <regis@google.com> Fri Aug 07 21:13:35 2020 +0000
committer commit-bot@chromium.org <commit-bot@chromium.org> Fri Aug 07 21:13:35 2020 +0000
tree 936a2827caa67e5fb9bcbf4c8fa9b1b2d471e5ff
parent 2060964faaf6ee6cd719a188ac95a85e88622290

Reland "[VM/runtime] Fix computation of the hash of recursive types."

This is a reland of a528b19d2c62eff86dc262409f9f873c78e23305

Updating the hash of the empty type argument vector in write-protected memory caused a crash in precomp mode.
The fix is to correctly initialize the hash so it does not need an update.

Original change's description:
> [VM/runtime] Fix computation of the hash of recursive types.
>
> When computing the hash of a type, only include the hashes of the type arguments corresponding to the type parameters of the type's class and not of the whole type argument vector, otherwise, the variable location of TypeRefs in the base class type arguments may result in different hashes.
>
> Add a regression test (this test was not failing in all configurations, since the issue becomes visible depending on the order in which types are loaded and finalized).
>
> This fixes issue https://github.com/dart-lang/sdk/issues/42954
>
> Small improvement: pick hash value 1 for a vector of dynamic types, so it can be cached and not recomputed repeatedly, which was the case with value 0.
>
> Change-Id: I3468952cbf61944a82cf8e00efbf4952bd831fbe
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157563
> Reviewed-by: Alexander Markov <alexmarkov@google.com>
> Commit-Queue: Régis Crelier <regis@google.com>

Change-Id: I538b4538c69472e09b7bd745c6bd41023e1f154f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157781
Commit-Queue: Régis Crelier <regis@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>