Make AnalysisError._contextMessages non-nullable
Change-Id: Icf85525d0003a2e6892f385c22128dd477a532ca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107160
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
diff --git a/pkg/analyzer/lib/error/error.dart b/pkg/analyzer/lib/error/error.dart
index d11d395..f8b3c13 100644
--- a/pkg/analyzer/lib/error/error.dart
+++ b/pkg/analyzer/lib/error/error.dart
@@ -796,8 +796,15 @@
*/
final ErrorCode errorCode;
+ /**
+ * The message describing the problem.
+ */
DiagnosticMessage _problemMessage;
+ /**
+ * The context messages associated with the problem. This list will be empty
+ * if there are no context messages.
+ */
List<DiagnosticMessage> _contextMessages;
/**
@@ -819,7 +826,8 @@
* [contextMessages] are provided, they will be recorded with the error.
*/
AnalysisError(this.source, int offset, int length, this.errorCode,
- [List<Object> arguments, List<DiagnosticMessage> contextMessages]) {
+ [List<Object> arguments,
+ List<DiagnosticMessage> contextMessages = const []]) {
String message = formatList(errorCode.message, arguments);
String correctionTemplate = errorCode.correction;
if (correctionTemplate != null) {
@@ -838,7 +846,7 @@
*/
AnalysisError.forValues(this.source, int offset, int length, this.errorCode,
String message, this._correction,
- {List<DiagnosticMessage> contextMessages}) {
+ {List<DiagnosticMessage> contextMessages = const []}) {
_problemMessage = new DiagnosticMessageImpl(
filePath: source?.fullName,
length: length,
@@ -847,7 +855,7 @@
_contextMessages = contextMessages;
}
- List<DiagnosticMessage> get contextMessages => _contextMessages ?? const [];
+ List<DiagnosticMessage> get contextMessages => _contextMessages;
/**
* Return the template used to create the correction to be displayed for this