| commit | f7ef66f5b0a2483a8a5daa7f8b0475b1d63c30ac | [log] [tgz] |
|---|---|---|
| author | Konstantin Shcheglov <scheglov@google.com> | Wed Jun 13 21:49:14 2018 +0000 |
| committer | commit-bot@chromium.org <commit-bot@chromium.org> | Wed Jun 13 21:49:14 2018 +0000 |
| tree | dedc545a8b952a8796895a6115e9eb7e58a8366e | |
| parent | aca417a256f4e3f3be28cc6c90185626d26be166 [diff] |
Issue 33412. Fix for race condition in knownFiles during search. In theory discoverAvailableFiles() should wait for all possibly known files to be discovered. But I think it is still possible to get the set of known files changed, e.g. when are asking asynchronoiusly for getIndex() and the user open a file that is not yet part of any driver. Only the second hunk of the change (inside subtypes()) is required for fixing the issue, the crucial change is toList() invocation. The switch from _driver.knownFiles to _driver.fsState.knownFiles is done to avoid one extra lookup for FileState. The first hunk (inside declarations()) is done just for consistency. Fixes https://github.com/dart-lang/sdk/issues/33412 R=paulberry@google.com Change-Id: I652ef7a156eba4bf0298c7e863dcef2b7c9f2b0e Reviewed-on: https://dart-review.googlesource.com/60142 Commit-Queue: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Paul Berry <paulberry@google.com>
Dart is an open-source, scalable programming language, with robust libraries and runtimes, for building web, server, and mobile apps.
Visit the dartlang.org to learn more about the language, tools, getting started, and more.
Browse pub.dartlang.org for more packages and libraries contributed by the community and the Dart team.
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.