)]}'
{
  "commit": "f709bf12f0e5147da0906b484f39de1fe65db912",
  "tree": "9686741a5c015e2d1ba177fc96c3c8d95d623b45",
  "parents": [
    "f36c55501ae2b88c9069f239c090ccb64e4787d4"
  ],
  "author": {
    "name": "Tess Strickland",
    "email": "sstrickl@google.com",
    "time": "Thu Jul 08 14:22:54 2021 +0000"
  },
  "committer": {
    "name": "commit-bot@chromium.org",
    "email": "commit-bot@chromium.org",
    "time": "Thu Jul 08 14:22:54 2021 +0000"
  },
  "message": "Reland \"[platform] Fix Utils::IsAbsoluteUint and rename to MagnitudeIsUint.\"\n\ndatastream.h is included in places where we cannot import the compiler\nnamespace, so we can\u0027t make compiler::target::word the type of\nWriteTargetWord. That also would possibly silently truncate a\nhost-word sized value that was passed in instead of alerting to a\npossible issue if those bits were important.\n\nHowever, just using IsInt fails if the value being passed in is\na compiler::target::uword that is larger than the max value\nthat fits in a compiler::target::word. Instead, check for\ntruncation by checking the bit length of the value, which works\nfor both signed and unsigned target word values.\n\nOriginal description:\n\nAlso remove previous (incorrect) uses in datastream.cc and\nimage_snapshot.cc, now that Utils::IsInt\u003cT\u003e(N, value) can now\nbe run for values of N \u003e\u003d sizeof(T).\n\nFixes https://github.com/dart-lang/sdk/issues/46572\n\nTEST\u003dlanguage/generic/super_bounded_types_test passes on NNBD simarm,\n     added value that triggered failure to vm/cc/MagnitudeIsUint\n\nCq-Include-Trybots: luci.dart.try:vm-kernel-nnbd-linux-release-simarm-try,vm-kernel-precomp-linux-debug-simarm_x64-try\nChange-Id: Idbfdda9f28243d206d482a1d9ac7ae76a5022ad2\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/206201\nReviewed-by: Daco Harkes \u003cdacoharkes@google.com\u003e\nCommit-Queue: Tess Strickland \u003csstrickl@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "98f1a1c523783485767830f1be0f727d55e1946a",
      "old_mode": 33188,
      "old_path": "runtime/platform/utils.h",
      "new_id": "a1d6b1b830ced931f84058fd224dee3a2cd5f15a",
      "new_mode": 33188,
      "new_path": "runtime/platform/utils.h"
    },
    {
      "type": "modify",
      "old_id": "7cf827213bf7372abd380ca99522acf903b479f7",
      "old_mode": 33188,
      "old_path": "runtime/vm/compiler/assembler/assembler_arm.cc",
      "new_id": "d285792ed578b61fcd9bab3f7e2cc45192005d4c",
      "new_mode": 33188,
      "new_path": "runtime/vm/compiler/assembler/assembler_arm.cc"
    },
    {
      "type": "modify",
      "old_id": "09162f4d4420b8069247c3ca548e259cdc8187a9",
      "old_mode": 33188,
      "old_path": "runtime/vm/compiler/assembler/assembler_arm.h",
      "new_id": "c41b62d1bea0d34bccfa84ab7f5928f4fa0733ed",
      "new_mode": 33188,
      "new_path": "runtime/vm/compiler/assembler/assembler_arm.h"
    },
    {
      "type": "modify",
      "old_id": "979db7ea0170e395ce8ca0388dbf8131481e499c",
      "old_mode": 33188,
      "old_path": "runtime/vm/compiler/backend/flow_graph_compiler_arm.cc",
      "new_id": "b71c702860440877485a679afefd9ae932b3ec8a",
      "new_mode": 33188,
      "new_path": "runtime/vm/compiler/backend/flow_graph_compiler_arm.cc"
    },
    {
      "type": "modify",
      "old_id": "80aaa4759f334cd908bae6a02e2a58e06cb37ca9",
      "old_mode": 33188,
      "old_path": "runtime/vm/compiler/backend/il_arm.cc",
      "new_id": "0c07ad2fe290e56af555c00f7c2a0d7170e50578",
      "new_mode": 33188,
      "new_path": "runtime/vm/compiler/backend/il_arm.cc"
    },
    {
      "type": "modify",
      "old_id": "6d398fe7597c226a9c64acf35041f1f2d13cab57",
      "old_mode": 33188,
      "old_path": "runtime/vm/datastream.cc",
      "new_id": "2dde0cfa6c0802fc6e822d29fb8b1043a22f146b",
      "new_mode": 33188,
      "new_path": "runtime/vm/datastream.cc"
    },
    {
      "type": "modify",
      "old_id": "658892bd5f5448b156271e41c8e197df14d0712e",
      "old_mode": 33188,
      "old_path": "runtime/vm/image_snapshot.cc",
      "new_id": "6be60de604b78fead0167ca0bf4d70e471209b50",
      "new_mode": 33188,
      "new_path": "runtime/vm/image_snapshot.cc"
    },
    {
      "type": "modify",
      "old_id": "ba4e296cb7bb7e99247ccdb18cb01a52876fc972",
      "old_mode": 33188,
      "old_path": "runtime/vm/utils_test.cc",
      "new_id": "2b0369f530db37dcffe390d87aa451994ef336aa",
      "new_mode": 33188,
      "new_path": "runtime/vm/utils_test.cc"
    }
  ]
}