commit f60b5bd855c588205931adb5112175d72bcda52c
author Sam Rawlins <srawlins@google.com> Thu Aug 15 01:00:16 2024 +0000
committer Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Aug 15 01:00:16 2024 +0000
tree 5c999ef9b3eb934c27c37b8718e95d2ea9154372
parent a8b661f4a7f7411468fb4f86d6ced3b29b79473d

DAS: Add digit separator tests for highlighting

Work towards https://github.com/dart-lang/sdk/issues/56188

Cq-Include-Trybots: luci.dart.try:flutter-analyze-try,analyzer-win-release-try,pkg-win-release-try
Change-Id: I852c9fe2301c297b8e5ae5b3157153774eaca740
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/380640
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>

pkg/analysis_server/test/analysis/notification_highlights2_test.dart

diff --git a/pkg/analysis_server/test/analysis/notification_highlights2_test.dart b/pkg/analysis_server/test/analysis/notification_highlights2_test.dart
index b6a3d92..e227fa2 100644
--- a/pkg/analysis_server/test/analysis/notification_highlights2_test.dart
+++ b/pkg/analysis_server/test/analysis/notification_highlights2_test.dart
@@ -1797,15 +1797,43 @@
   }
 
   Future<void> test_LITERAL_DOUBLE() async {
-    addTestFile('var V = 4.2;');
+    addTestFile('''
+var V1 = 4.2;
+var V2 = 1_2.3_4;
+var V3 = 33e44;
+var V4 = 3_3e4_4;
+var V5 = 33.44e55;
+var V6 = 3_3.4_4e5_5;
+''');
     await prepareHighlights();
     assertHasRegion(HighlightRegionType.LITERAL_DOUBLE, '4.2;', '4.2'.length);
+    assertHasRegion(
+        HighlightRegionType.LITERAL_DOUBLE, '1_2.3_4;', '1_2.3_4'.length);
+    assertHasRegion(
+        HighlightRegionType.LITERAL_DOUBLE, '33e44;', '33e44'.length);
+    assertHasRegion(
+        HighlightRegionType.LITERAL_DOUBLE, '3_3e4_4;', '3_3e4_4'.length);
+    assertHasRegion(
+        HighlightRegionType.LITERAL_DOUBLE, '33.44e55;', '33.44e55'.length);
+    assertHasRegion(HighlightRegionType.LITERAL_DOUBLE, '3_3.4_4e5_5;',
+        '3_3.4_4e5_5'.length);
   }
 
   Future<void> test_LITERAL_INTEGER() async {
-    addTestFile('var V = 42;');
+    addTestFile('''
+var V1 = 42;
+var V2 = 1_000_000;
+var V3 = 0x123;
+var V4 = 0x12_34;
+''');
     await prepareHighlights();
     assertHasRegion(HighlightRegionType.LITERAL_INTEGER, '42;');
+    assertHasRegion(
+        HighlightRegionType.LITERAL_INTEGER, '1_000_000;', '1_000_000'.length);
+    assertHasRegion(
+        HighlightRegionType.LITERAL_INTEGER, '0x123;', '0x123'.length);
+    assertHasRegion(
+        HighlightRegionType.LITERAL_INTEGER, '0x12_34;', '0x12_34'.length);
   }
 
   Future<void> test_LITERAL_LIST() async {