| commit | f5ec9b05549127bae52f8934ed3eab0f46188cea | [log] [tgz] |
|---|---|---|
| author | Erik Ernst <eernst@google.com> | Fri Sep 14 08:56:22 2018 +0000 |
| committer | Erik Ernst <eernst@google.com> | Fri Sep 14 08:56:22 2018 +0000 |
| tree | f6177e9ac0c2a90bb216288533504e91c506f73e | |
| parent | a16c7d899a93261e84d6b87c16ead622c5ffb9ae [diff] |
This CL changes some status comments, but also points out an issue. The point is that #32782 requests a fix such that `typedef F1 = void Function(int)` and `typedef void F2(int)` satisfy that `F1 == F2` evaluates to true. This is marked 'p3-low' for the common front end but 'p1-high' for DDC. It seems likely to me that this could create the situation where code is developed using DDC, is working, and then fails upon deployment using the vm. Also, there is a single case where `dart2js` fails in the associated `type_alias_equality_test.dart`, so deployment on the web would also fail upon deployment, though only in some of the cases. However, with some input from Aske I concluded that the situation might have arisen because there _is_ no work to do for this in the common front end, because it will be handled by the backend (which also explains why `dart2js` has it almost right). This CL is just introducing a tiny change: It changes the issue indicated for all VM related failures in said test to point to #32783, which is presumably the right issue for backend work. Apart from that, I've added you, the reviewers, in order to make sure that the relevant people get this heads up. We may then decide to land this CL, change the priority on #31359, do nothing, or whatever turns out to be the right response. ;-) Change-Id: I92672547d7fe795e877604c0da1e0e4579e4e04a Reviewed-on: https://dart-review.googlesource.com/74403 Reviewed-by: Jenny Messerly <jmesserly@google.com>
Dart is an open-source, scalable programming language, with robust libraries and runtimes, for building web, server, and mobile apps.
Visit the dartlang.org to learn more about the language, tools, getting started, and more.
Browse pub.dartlang.org for more packages and libraries contributed by the community and the Dart team.
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.