commit f47754906a7b4a916330c227ff1f9bc61fce7b2c
author Paul Berry <paulberry@google.com> Thu Apr 07 16:58:48 2022 +0000
committer Commit Bot <commit-bot@chromium.org> Thu Apr 07 16:58:48 2022 +0000
tree 175a6ae8cdf5632e12549ad776e70fdaf679f3b1
parent 240f1c90a1e44e2343c1f116736a3bb2a4bc1600

Clean up the use of rawType in InvocationInferrer.

In some follow-up work I'm doing with the `InvocationInferrer` class
hierarchy to support https://github.com/dart-lang/language/issues/731,
I've been getting confused due to the fact that `rawType` is:

- a final field in the base class

- a non-final local variable in the
  `FullInvocationInferrer.resolveInvocation` method, which sometimes
  matches the final field and sometimes doesn't, and

- a parameter of some methods in the class hierarchy.

This change makes the field non-final and updates it as needed so that
it always matches the value of the non-final local variable in
`FullInvocationInferrer.resolveInvocation`.  (I would have preferred
to eliminate the local variable entirely, but it would have led to far
too many nuisance null checks).  It also eliminates some unnecessary
method parameters.

Change-Id: I204ef93b5e3433edb9066519ec5d01dd3dfa7f08
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/240461
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>