| commit | f36ab38bf3ca9eb80cf8bdede5c5eeb6afed74de | [log] [tgz] |
|---|---|---|
| author | Jens Johansen <jensj@google.com> | Tue Aug 07 09:10:08 2018 +0000 |
| committer | commit-bot@chromium.org <commit-bot@chromium.org> | Tue Aug 07 09:10:08 2018 +0000 |
| tree | 8090b3e56f25c69e47a9d795259ec9014de2c313 | |
| parent | f6a74b0412925288caad9ce2bd7fa9e8fe732a36 [diff] |
Detect isKernel better in service tests Change-Id: I38ef62dd7db1dbda8bdc0477d16f92192cf8bff3 Reviewed-on: https://dart-review.googlesource.com/68621 Reviewed-by: Kevin Millikin <kmillikin@google.com> Commit-Queue: Jens Johansen <jensj@google.com>
diff --git a/runtime/observatory/tests/service/service.status b/runtime/observatory/tests/service/service.status index ccbe75b..daee1cb 100644 --- a/runtime/observatory/tests/service/service.status +++ b/runtime/observatory/tests/service/service.status
@@ -78,12 +78,6 @@ [ $mode == debug && ($arch == simarm || $arch == simarm64) ] *: SkipSlow -[ $runtime == vm && ($compiler == app_jit || $compiler == none) ] -coverage_leaf_function_test: RuntimeError -coverage_optimized_function_test: RuntimeError -get_object_rpc_test: RuntimeError # Spawned process runs in Dart2 mode -get_source_report_test: RuntimeError # Spawned process runs in Dart2 mode - [ !$strong && ($compiler == dartk || $compiler == dartkp) ] *: Skip
diff --git a/runtime/observatory/tests/service/service_test_common.dart b/runtime/observatory/tests/service/service_test_common.dart index 15f0007..e9add47 100644 --- a/runtime/observatory/tests/service/service_test_common.dart +++ b/runtime/observatory/tests/service/service_test_common.dart
@@ -554,6 +554,7 @@ bool isKernel() { for (String argument in Platform.executableArguments) { if (argument.startsWith("--no-preview_dart_2")) return false; + if (argument.startsWith("--no-preview-dart-2")) return false; } return true; }