commit f2591206edd8bbfed9968dd639339e14ec3f9ebc
author Konstantin Shcheglov <scheglov@google.com> Wed Apr 09 09:56:01 2025 -0700
committer Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Apr 09 09:56:01 2025 -0700
tree 41869a62c2baeab548e2fbf8fa05fa9964193a71
parent d510876d9e44fd13913ce49567ceb3059d7f38df

Elements. Remove withCheckingLinking flag.

The corresponding issue was fixed, and I think maybe try to do
linking check for all AST nodes.

Change-Id: I6f5cab635ce795fd2cece37d7af0d6f849ecfb33
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/421540
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>

pkg/analyzer/test/src/diagnostics/parser_diagnostics.dart

diff --git a/pkg/analyzer/test/src/diagnostics/parser_diagnostics.dart b/pkg/analyzer/test/src/diagnostics/parser_diagnostics.dart
index 69895b2..ec78cef 100644
--- a/pkg/analyzer/test/src/diagnostics/parser_diagnostics.dart
+++ b/pkg/analyzer/test/src/diagnostics/parser_diagnostics.dart
@@ -21,13 +21,11 @@
   void assertParsedNodeText(
     AstNode node,
     String expected, {
-    bool withCheckingLinking = false,
     bool withOffsets = false,
     bool withTokenPreviousNext = false,
   }) {
     var actual = _parsedNodeText(
       node,
-      withCheckingLinking: withCheckingLinking,
       withOffsets: withOffsets,
       withTokenPreviousNext: withTokenPreviousNext,
     );
@@ -68,7 +66,6 @@
 
   String _parsedNodeText(
     AstNode node, {
-    required bool withCheckingLinking,
     required bool withOffsets,
     required bool withTokenPreviousNext,
   }) {
@@ -86,7 +83,6 @@
         sink: sink,
         elementPrinter: elementPrinter,
         configuration: ResolvedNodeTextConfiguration()
-          ..withCheckingLinking = withCheckingLinking
           ..withTokenPreviousNext = withTokenPreviousNext,
         withResolution: false,
         withOffsets: withOffsets,

pkg/analyzer/test/src/fasta/ast_builder_test.dart

diff --git a/pkg/analyzer/test/src/fasta/ast_builder_test.dart b/pkg/analyzer/test/src/fasta/ast_builder_test.dart
index 8642a11..d67abd0 100644
--- a/pkg/analyzer/test/src/fasta/ast_builder_test.dart
+++ b/pkg/analyzer/test/src/fasta/ast_builder_test.dart
@@ -1045,9 +1045,7 @@
     ]);
 
     var node = parseResult.findNode.enumConstantDeclaration('v<int>');
-    assertParsedNodeText(
-        node,
-        r'''
+    assertParsedNodeText(node, r'''
 EnumConstantDeclaration
   name: v
   arguments: EnumConstantArguments
@@ -1064,8 +1062,7 @@
     argumentList: ArgumentList
       leftParenthesis: ( <synthetic>
       rightParenthesis: ) <synthetic>
-''',
-        withCheckingLinking: true);
+''');
   }
 
   void test_enum_constant_withTypeArgumentsWithoutArguments() {

pkg/analyzer/test/src/summary/resolved_ast_printer.dart

diff --git a/pkg/analyzer/test/src/summary/resolved_ast_printer.dart b/pkg/analyzer/test/src/summary/resolved_ast_printer.dart
index af719ed..c06aea3 100644
--- a/pkg/analyzer/test/src/summary/resolved_ast_printer.dart
+++ b/pkg/analyzer/test/src/summary/resolved_ast_printer.dart
@@ -493,9 +493,7 @@
 
   @override
   void visitEnumConstantArguments(EnumConstantArguments node) {
-    if (configuration.withCheckingLinking) {
-      _checkChildrenEntitiesLinking(node);
-    }
+    _checkChildrenEntitiesLinking(node);
     _sink.writeln('EnumConstantArguments');
     _sink.withIndent(() {
       _writeNamedChildEntities(node);
@@ -1471,9 +1469,7 @@
 
   @override
   void visitSuperFormalParameter(SuperFormalParameter node) {
-    if (configuration.withCheckingLinking) {
-      _checkChildrenEntitiesLinking(node);
-    }
+    _checkChildrenEntitiesLinking(node);
     _sink.writeln('SuperFormalParameter');
     _sink.withIndent(() {
       _writeNamedChildEntities(node);
@@ -2080,10 +2076,6 @@
 class ResolvedNodeTextConfiguration {
   bool skipArgumentList = false;
 
-  /// If `true`, linking of [EnumConstantDeclaration] will be checked
-  // TODO(scheglov): Remove after https://github.com/dart-lang/sdk/issues/48380
-  bool withCheckingLinking = false;
-
   /// If `true`, elements of [InterfaceType] should be printed.
   bool withInterfaceTypeElements = false;