Revert "analyzer: Refactor @doNotStore-usage reporting using ElementUsageReporter"

This reverts commit c86cb6aa9a7820ec4720c7cf744b2081ef8784c0.

Reason for revert: Performance regression

Original change's description:
> analyzer: Refactor @doNotStore-usage reporting using ElementUsageReporter
>
> Work towards https://github.com/dart-lang/sdk/issues/62253
>
> This necessitates three behavioral changes:
>
> 1. The reported range changes FROM an entire method invocation, for
>    example, including the target and the method name and the argument
>    list, TO just the method name. This aligns with our principles and
>    how other diagnostics like this are reported.
> 2. A different warning is reported in the
>    `test_topLevelVariable_assignment_functionExpression` test case:
>    code like `var c = () => _v;` where `_v` is annotated with
>    `@doNotStore`. It used to be "assignment of do not store" and now it
>    is "return of do not store." I think this is also more correct, and
>    the logic behind the previous logic probably just has a subtle bug.
> 3. A few more expression types are counted as "storage" of a value,
>    when paired with a return statement or an assignment:
>    * as-expression
>    * target of cascage
>    * dot-shorthand property access
>    * null assert
>    * case-body of a switch-expression
>
> Change-Id: Ic3e6ad23ddbe181885f9854a891d0112fb679e8b
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/478701
> Commit-Queue: Samuel Rawlins <srawlins@google.com>
> Reviewed-by: Paul Berry <paulberry@google.com>
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: Ic225f4732bedbdba2885954d4c5bad7a55eb80a8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/481840
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
10 files changed
tree: e281f1d161859c030e17b1de4c6e4602bb23dbca
  1. .dart_tool/
  2. .github/
  3. benchmarks/
  4. build/
  5. docs/
  6. pkg/
  7. runtime/
  8. samples/
  9. sdk/
  10. tests/
  11. third_party/
  12. tools/
  13. utils/
  14. .clang-format
  15. .gitattributes
  16. .gitconfig
  17. .gitignore
  18. .gn
  19. .mailmap
  20. .style.yapf
  21. AUTHORS
  22. BUILD.gn
  23. CHANGELOG.md
  24. codereview.settings
  25. CONTRIBUTING.md
  26. DEPS
  27. LICENSE
  28. OWNERS
  29. PATENT_GRANT
  30. PRESUBMIT.py
  31. pubspec.yaml
  32. README.dart-sdk
  33. README.md
  34. sdk.code-workspace
  35. sdk_args.gni
  36. sdk_packages.yaml
  37. SECURITY.md
  38. WATCHLISTS
README.md

Dart

An approachable, portable, and productive language for high-quality apps on any platform

Dart is:

  • Approachable: Develop with a strongly typed programming language that is consistent, concise, and offers modern language features like null safety and patterns.

  • Portable: Compile to ARM, x64, or RISC-V machine code for mobile, desktop, and backend. Compile to JavaScript or WebAssembly for the web.

  • Productive: Make changes iteratively: use hot reload to see the result instantly in your running app. Diagnose app issues using DevTools.

Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:

  • Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.

  • Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).

Dart platforms illustration

License & patents

Dart is free and open source.

See LICENSE and PATENT_GRANT.

Using Dart

Visit dart.dev to learn more about the language, tools, and to find codelabs.

Browse pub.dev for more packages and libraries contributed by the community and the Dart team.

Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).

Building Dart

If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.

There are more documents in our repo at docs.

Contributing to Dart

The easiest way to contribute to Dart is to file issues.

You can also contribute patches, as described in Contributing.

Roadmap

Future plans for Dart are included in the combined Dart and Flutter roadmap on the Flutter wiki.