commit e63cea6634a46b59f8c14f94b4f253f4f0d0cfba
author Paul Berry <paulberry@google.com> Thu Apr 21 12:33:18 2022 +0000
committer Commit Bot <commit-bot@chromium.org> Thu Apr 21 12:33:18 2022 +0000
tree c2c315fc9cb4735000f90d7fecbbbae675192d54
parent 28654b90e8ef4022bc80496c7198e96b61760fc7

Unify named and unnamed argument handling logic for invocations.

In order to support https://github.com/dart-lang/language/issues/731
(improved inference for fold etc.) I'm going to need to add logic to
_inferInvocation to postpone type analysis of arguments that are
function expressions.  To avoid having to code up this logic twice, it
will be helpful to have both named and unnamed arguments handled by
the same chunk of code.

In particular, this change unifies the computation of
inferredFormalType, the recursive call to inferExpression, the logic
for hoisting, and the update of the local variables identicalInfo,
formalTypes, and actualTypes.  We pay a small price by having to have
multiple `if (isExpression)` checks, but these should be very fast.

Change-Id: I095a7eac84237eeb878cc3dd86e76a6a871f31d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/241041
Reviewed-by: Chloe Stefantsova <cstefantsova@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>