| commit | ee3a86d8ab003de1085b9ed60c7be04ebb7f6724 | [log] [tgz] |
|---|---|---|
| author | Ryan Macnak <rmacnak@google.com> | Mon Apr 05 22:48:16 2021 +0000 |
| committer | commit-bot@chromium.org <commit-bot@chromium.org> | Mon Apr 05 22:48:16 2021 +0000 |
| tree | 7a8e8378d3dbad5f148a308b9664a6f24d97f5fd | |
| parent | 06729f230a38761c51b9aaeac88f0bb32b90c3f8 [diff] |
[vm] Avoid data race querying the new-space page cache. This access is extremely infrequent, so we may as well consistently use the mutex. TEST=tsan Bug: https://github.com/dart-lang/sdk/issues/45521 Change-Id: I17b276f671e20c2eed8bf26735cc11c386fba9e6 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/194013 Reviewed-by: Alexander Aprelev <aam@google.com> Commit-Queue: Ryan Macnak <rmacnak@google.com>
diff --git a/runtime/vm/heap/scavenger.cc b/runtime/vm/heap/scavenger.cc index bdc785c..f0dee56 100644 --- a/runtime/vm/heap/scavenger.cc +++ b/runtime/vm/heap/scavenger.cc
@@ -670,6 +670,7 @@ } intptr_t SemiSpace::CachedSize() { + MutexLocker ml(page_cache_mutex); return page_cache_size * kNewPageSize; }