tree 3f9eebb6b2f487b9b3030f66bcc05eb035666426
parent 1a56334ec594d5f494c7e178a08e90e9c60a97e9
author Paul Berry <paulberry@google.com> 1770012624 -0800
committer Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> 1770012624 -0800

[messages] Stop using withArgumentsOld, batch 15.

This is one of several planned batches of changes to transition the
front end (and related packages) away from the old `withArgumentsOld`
diagnostic reporting method, and to the new `withArguments`
method. The difference between the two is that `withArguments` has
named parameters rather than positional ones, so (a) it's less likely
for parameters to be mixed up, and (b) it's compatible with the
calling conventions used by analyzer diagnostics.

As part of this transition, I'm taking the opportunity to rename the
parameters themselves (since the names previously were restricted to a
very small set of possibilities based on type), and to document them
in `messages.yaml`. To avoid fatigue (both for myself and code
reviewers), I've chosen to break the change into many smaller batches.

The only changes in this CL that were manually written are those in
`messages.yaml`. The others were produced by running the standard
diagnostic message code generator and then running the script
`use_new_with_arguments.dart`.

Change-Id: I6a6a6964d5222d76719f426a8632cf778694bd34
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/477100
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>