Google Git
Sign in
dart / sdk / ed1e0e199eceb4ce0b0530acdb231f0c3bc989bc
commited1e0e199eceb4ce0b0530acdb231f0c3bc989bc[log] [tgz]
authorMartin Kustermann <kustermann@google.com>Wed Oct 16 12:40:12 2019 +0000
committercommit-bot@chromium.org <commit-bot@chromium.org>Wed Oct 16 12:40:12 2019 +0000
treeea99d6d510b53c41d037f4b028c985f31d9a2404
parent23e8f2bcfa045471e4ed7c7834c04760f2fc6b43 [diff]
[vm/ffi] Handle IntConverter's similar to LoadUntagged in load optimizer

Our LoadIndexedInstr/StoreIndexedInstr can operate on an untagged array,
for which we assume it can alias with anything (despite constant
index).

Optimized dart:ffi code will create LoadIndexedInstr/StoreIndexedInstr
that operate on IntConverterInstr. Those can be views into arbitrary
memory so we should assume it can alias with anything (despite constant
index).

Right now it happens to be not a problem (and we cannot have a Dart test
to trigger it), because every LoadIndexedInstr/StoreIndexedInstr that

dart:ffi code generates happens to use a 0 index: It will load the
address of the pointer, adds the scaled index to it and then converts
the result of this arithmetic to an untagged pointer, used by the
load/store with index 0.
Change-Id: I94268486603b78e4d21c3dafaccd133da35193f3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121843
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
1 file changed
tree: ea99d6d510b53c41d037f4b028c985f31d9a2404
  1. .github/
  2. benchmarks/
  3. build/
  4. client/
  5. docs/
  6. pkg/
  7. runtime/
  8. samples/
  9. samples-dev/
  10. sdk/
  11. sdk_nnbd/
  12. tests/
  13. third_party/
  14. tools/
  15. utils/
  16. .clang-format
  17. .gitattributes
  18. .gitconfig
  19. .gitignore
  20. .gn
  21. .mailmap
  22. .packages
  23. .style.yapf
  24. .vpython
  25. AUTHORS
  26. BUILD.gn
  27. CHANGELOG.md
  28. codereview.settings
  29. CONTRIBUTING.md
  30. DEPS
  31. LICENSE
  32. PATENT_GRANT
  33. PRESUBMIT.py
  34. README.dart-sdk
  35. README.md
  36. sdk_args.gni
  37. WATCHLISTS
README.md

Dart

A client-optimized language for fast apps on any platform

Dart is:

  • Optimized for UI: Develop with a programming language specialized around the needs of user interface creation

  • Productive: Make changes iteratively: use hot reload to see the result instantly in your running app

  • Fast on all platforms: Compile to ARM & x64 machine code for mobile, desktop, and backend. Or compile to JavaScript for the web

Dart has flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:

  • Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.

  • Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).

Dart platforms illustration

License & patents

Dart is free and open source.

See LICENSE and PATENT_GRANT.

Using Dart

Visit the dart.dev to learn more about the language, tools, getting started, and more.

Browse pub.dev for more packages and libraries contributed by the community and the Dart team.

Building Dart

If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.

There are more documents on our wiki.

Contributing to Dart

The easiest way to contribute to Dart is to file issues.

You can also contribute patches, as described in Contributing.