commit ec6d9c05d29a4c72a2f1afe052ed194f5ff545ec
author Ömer Sinan Ağacan <omersa@google.com> Tue Dec 10 09:34:28 2024 +0000
committer Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Dec 10 09:34:28 2024 +0000
tree 5cdecb2fa27f8d6f44175a2629d426dc4026fdeb
parent 0c527e1b9f187c823263d19f9a3c2df8a76ccc22

[dart2wasm] Inline Pointer constructor

Currently none of dart2wasm or wasm-opt inline `Pointer._`, resulting in
bad code generation when the allocated pointers are directly unboxed.
Example:

```
import 'dart:ffi';

@Native<Pointer<Int64> Function()>()
external Pointer<Int64> intPtr();

@Native<Int64 Function(Pointer<Int64>)>()
external int derefIntPtr(Pointer<Int64> ptr);

void main() {
  Pointer<Int64> ptr = intPtr();
  ptr += 1;
  int i = derefIntPtr(ptr);
  print(i);
}
```

Current output:

```
(func $main (;299;)
  i32.const 83
  call $ffi.intPtr (import)
  call $Pointer._
  struct.get $_Type $field2
  i32.const 8
  i32.add
  call $Pointer._
  struct.get $_Type $field2
  call $ffi.derefIntPtr (import)
  struct.new $BoxedInt
  call $print)
```

With this CL the `Pointer` allocation disappears:

```
(func $main (;299;)
  i32.const 83
  call $ffi.intPtr (import)
  i32.const 8
  i32.add
  call $ffi.derefIntPtr (import)
  struct.new $BoxedInt
  call $print)
```

Change-Id: I54a2fd37bc9e8ab26c6394e0b8175d65ecf64cb4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/399561
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Ömer Ağacan <omersa@google.com>