commit e8ed4989026da45ea09f3d9dae230aff8f702a23
author Jonas Termansen <sortie@google.com> Fri Mar 22 12:21:39 2024 +0000
committer Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Mar 22 12:21:39 2024 +0000
tree 61f4f584c168c8dd3090f5670fd51a0d8ffd33f3
parent 1cebdcb2da217ca264d2dfb245c081296852b2bf

[infra] Remove --no-goma from test matrix.

Goma is off by default, and RBE is only enabled where it is known to
work, so there is no need to disable RBE instead. Some of these builders
additionally disable RBE in their infra/config definitions and there is
no need to duplicate that information here.

Bug: b/296994239
Change-Id: I9f9733ba5189b53b899289a23d68126f7c6adcc5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/357610
Commit-Queue: Jonas Termansen <sortie@google.com>
Reviewed-by: William Hesse <whesse@google.com>

tools/bots/test_matrix.json

diff --git a/tools/bots/test_matrix.json b/tools/bots/test_matrix.json
index 8ddddce..475e0f8 100644
--- a/tools/bots/test_matrix.json
+++ b/tools/bots/test_matrix.json
@@ -1383,7 +1383,6 @@
             "--mode=debug",
             "--arch=ia32",
             "--no-clang",
-            "--no-goma",
             "runtime"
           ]
         },
@@ -1394,7 +1393,6 @@
             "--mode=debug",
             "--arch=x64",
             "--no-clang",
-            "--no-goma",
             "runtime",
             "runtime_precompiled"
           ]
@@ -1406,7 +1404,6 @@
             "--mode=debug",
             "--arch=riscv64",
             "--no-clang",
-            "--no-goma",
             "runtime",
             "runtime_precompiled"
           ]
@@ -1418,7 +1415,6 @@
             "--mode=release",
             "--arch=ia32",
             "--no-clang",
-            "--no-goma",
             "runtime"
           ]
         },
@@ -1429,7 +1425,6 @@
             "--mode=release",
             "--arch=x64",
             "--no-clang",
-            "--no-goma",
             "runtime",
             "runtime_precompiled"
           ]
@@ -1441,7 +1436,6 @@
             "--mode=release",
             "--arch=riscv64",
             "--no-clang",
-            "--no-goma",
             "runtime",
             "runtime_precompiled"
           ]
@@ -1463,7 +1457,6 @@
             "--mode=debug",
             "--arch=arm64",
             "--no-clang",
-            "--no-goma",
             "runtime",
             "runtime_precompiled"
           ]
@@ -1475,7 +1468,6 @@
             "--mode=release",
             "--arch=arm64",
             "--no-clang",
-            "--no-goma",
             "runtime",
             "runtime_precompiled"
           ]
@@ -1487,7 +1479,6 @@
             "--mode=product",
             "--arch=arm64",
             "--no-clang",
-            "--no-goma",
             "runtime",
             "runtime_precompiled"
           ]
@@ -1499,7 +1490,6 @@
             "--mode=debug",
             "--arch=x64",
             "--no-clang",
-            "--no-goma",
             "runtime",
             "runtime_precompiled"
           ]
@@ -1511,7 +1501,6 @@
             "--mode=release",
             "--arch=x64",
             "--no-clang",
-            "--no-goma",
             "runtime",
             "runtime_precompiled"
           ]
@@ -1523,7 +1512,6 @@
             "--mode=product",
             "--arch=x64",
             "--no-clang",
-            "--no-goma",
             "runtime",
             "runtime_precompiled"
           ]
@@ -1611,7 +1599,6 @@
           "name": "build dart",
           "script": "tools/build.py",
           "arguments": [
-            "--no-goma",
             "runtime"
           ]
         },
@@ -1637,7 +1624,6 @@
           "name": "build dart",
           "script": "tools/build.py",
           "arguments": [
-            "--no-goma",
             "dart_precompiled_runtime",
             "gen_snapshot",
             "runtime"
@@ -1667,7 +1653,6 @@
           "name": "build dart",
           "script": "tools/build.py",
           "arguments": [
-            "--no-goma",
             "--no-clang",
             "runtime"
           ]
@@ -1702,7 +1687,6 @@
           "name": "build dart",
           "script": "tools/build.py",
           "arguments": [
-            "--no-goma",
             "--no-clang",
             "dart_precompiled_runtime",
             "gen_snapshot",