| commit | 46e5954b0a0280e54270873b3d2616ed2aa90482 | [log] [tgz] |
|---|---|---|
| author | Paul Berry <paulberry@google.com> | Fri Sep 21 01:06:25 2018 +0000 |
| committer | commit-bot@chromium.org <commit-bot@chromium.org> | Fri Sep 21 01:06:25 2018 +0000 |
| tree | 9ca3562641c4494ceee826e7b9ab43576a1745d0 | |
| parent | b7f762923ef390986443501a2cc8a1153d3ac610 [diff] |
Turn on and fix mixin type inference checks when not in "supermixin" mode. Now that we have an explicit syntax for mixins that is available all the time, we have to do mixin inference error checking all the time, not just when the "--supermixin" flag is supplied. This required fixing several minor bugs: - ErrorVerifier._checkForMixinSuperInvokedMembers did not properly handle a mixinElement argument that was a ClassElementHandle. - ErrorVerifier._checkMixinInference wasn't using the actual substituted mixin types, causing errors to be wrongly reported when a class declaration had multiple inferred mixins (this was the root cause of #34404). - Type names in "with" clauses in the resolved AST weren't properly reflecting the mixin type arguments that had been inferred. Fixes #34404. Change-Id: Ia773233c66f8d9ab778f207689c73922e9e3a880 Reviewed-on: https://dart-review.googlesource.com/75792 Commit-Queue: Paul Berry <paulberry@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Dart is an open-source, scalable programming language, with robust libraries and runtimes, for building web, server, and mobile apps.
Visit the dartlang.org to learn more about the language, tools, getting started, and more.
Browse pub.dartlang.org for more packages and libraries contributed by the community and the Dart team.
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.