| commit | e67222a92b681231f39128024dfa8bfb5ac00324 | [log] [tgz] |
|---|---|---|
| author | Vyacheslav Egorov <vegorov@google.com> | Wed May 09 18:01:57 2018 +0000 |
| committer | commit-bot@chromium.org <commit-bot@chromium.org> | Wed May 09 18:01:57 2018 +0000 |
| tree | 1d2b22599e7120b3926bb55a05853b07882273fc | |
| parent | 5afa2dca51b2619223116d20a485fd842edd33a9 [diff] |
[vm/compiler] Do not use call->ArgumentAt(0) to access receiver. If call can have type arguments we can't use call->ArgumentAt(0) to access receiver, instead we need to use call->ArgumentAt(call->FirstArgIndex()). This lead to a bug in polymorphic inlining of functions with type arguments - instead of loading class id from the receiver we would be loading it from the first argument which contains type arguments. This CL also cleans up other parts of the compiler that used ArgumentAt(0) when they needed receiver. Fixes https://github.com/dart-lang/protobuf/issues/95 Change-Id: I5504f7aff714894ff9fe580710c376f1d1933bfa Reviewed-on: https://dart-review.googlesource.com/54411 Reviewed-by: Alexander Markov <alexmarkov@google.com> Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Dart is an open-source, scalable programming language, with robust libraries and runtimes, for building web, server, and mobile apps.
Visit the dartlang.org to learn more about the language, tools, getting started, and more.
Browse pub.dartlang.org for more packages and libraries contributed by the community and the Dart team.
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.