Google Git
Sign in
dart / sdk / e501a8e2e4075524587698d0264420ddca3bef37
commite501a8e2e4075524587698d0264420ddca3bef37[log] [tgz]
authorSam Rawlins <srawlins@google.com>Wed Apr 13 16:41:52 2022 +0000
committerCommit Bot <commit-bot@chromium.org>Wed Apr 13 16:41:52 2022 +0000
treeaafd9ee4bddf0d36792ef59a810900417decea04
parentcf2f4fc4cc0f4927462d64a07150b53f266d288c [diff]
Add short-circuiting to _DeclarationByElementLocator

This should speed up `ParsedLibraryResultImpl.getElementDeclaration` and
`ResolvedLibaryResultImpl.getElementDeclaration`, each of which is used
by various functions in analysis_server.

dartdoc currently uses NodeLocator2 to find declarations, which is
blazingly fast. However, I need to change dartdoc to instead use
`ResolvedLibaryResultImpl.getElementDeclaration`. But this function, as
is, is incredibly slow. It would significantly slow down dartdoc to use
`getElementDeclaration` as is.

I tested with dartdoc, documenting a synthetic package with 2 libraries,
each with 10 classes, each with 1 method with 1 parameter. Times spent
in each visitor (many calls each):

* current NodeLocator2 impl:                         12 ms
* current _DeclarationByElementLocator impl:     92_000 ms
* _DeclarationByElementLocator with this change:    650 ms

Change-Id: I4cf9ab6adf4fc53cb93dab03b12d772226a4f3f2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/241060
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
1 file changed
tree: aafd9ee4bddf0d36792ef59a810900417decea04
  1. .dart_tool/
  2. .github/
  3. benchmarks/
  4. build/
  5. docs/
  6. pkg/
  7. runtime/
  8. samples/
  9. samples-dev/
  10. samples_2/
  11. sdk/
  12. tests/
  13. third_party/
  14. tools/
  15. utils/
  16. .clang-format
  17. .gitattributes
  18. .gitconfig
  19. .gitignore
  20. .gn
  21. .mailmap
  22. .style.yapf
  23. .vpython
  24. AUTHORS
  25. BUILD.gn
  26. CHANGELOG.md
  27. codereview.settings
  28. compile_output.txt
  29. CONTRIBUTING.md
  30. DEPS
  31. LICENSE
  32. OWNERS
  33. PATENT_GRANT
  34. PRESUBMIT.py
  35. README.dart-sdk
  36. README.md
  37. sdk_args.gni
  38. SECURITY.md
  39. WATCHLISTS
README.md

Dart

A client-optimized language for fast apps on any platform

Dart is:

  • Optimized for UI: Develop with a programming language specialized around the needs of user interface creation.

  • Productive: Make changes iteratively: use hot reload to see the result instantly in your running app.

  • Fast on all platforms: Compile to ARM & x64 machine code for mobile, desktop, and backend. Or compile to JavaScript for the web.

Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:

  • Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.

  • Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).

Dart platforms illustration

License & patents

Dart is free and open source.

See LICENSE and PATENT_GRANT.

Using Dart

Visit dart.dev to learn more about the language, tools, and to find codelabs.

Browse pub.dev for more packages and libraries contributed by the community and the Dart team.

Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).

Building Dart

If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.

There are more documents on our wiki.

Contributing to Dart

The easiest way to contribute to Dart is to file issues.

You can also contribute patches, as described in Contributing.