)]}' { "commit": "e14472c46b64c1fb9ba9f29401e790985bb78943", "tree": "c2dc66caf8059c77e504b2ce30ba06dfe8e655ef", "parents": [ "555485c891bd109785ad1450e4670b76ea70270e" ], "author": { "name": "Johnni Winther", "email": "johnniwinther@google.com", "time": "Mon Jan 07 15:01:10 2019 +0000" }, "committer": { "name": "commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Mon Jan 07 15:01:10 2019 +0000" }, "message": "Use getters/setters found through the static types.\n\nThis uses the information from the static types now used in inference which\ncan improve the precision in particular for generic classes. Since type\nmasks lose the type argument information, we cannot expect locating members\nbased on the type mask to be more precise than what has been found through\nthe static types.\n\nThis CL also expands the unit test framework to support unit test of\noptimizations and the emission model, including tests of the improved\nfield access handling.\n\nCloses #35433\n\nChange-Id: Ia5de15efaf8b60c8723943bb34de6eec7d380798\nReviewed-on: https://dart-review.googlesource.com/c/88440\nReviewed-by: Stephen Adams \u003csra@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "e277dd8e1b173cffa0f8d35b5f0b0336986fb66b", "old_mode": 33188, "old_path": "pkg/compiler/lib/src/js_model/js_world.dart", "new_id": "39e86a0864298a544ea621942420dbdcf67ec7e8", "new_mode": 33188, "new_path": "pkg/compiler/lib/src/js_model/js_world.dart" }, { "type": "modify", "old_id": "3ce50846c1c0b81cafbd1bce931bb71d1094711d", "old_mode": 33188, "old_path": "pkg/compiler/lib/src/ssa/builder_kernel.dart", "new_id": "1c14b38aa6f2b604ba809425c8a31827dabd9a65", "new_mode": 33188, "new_path": "pkg/compiler/lib/src/ssa/builder_kernel.dart" }, { "type": "modify", "old_id": "05c7a6ec90e1e5bb72f4a0ba9156bf2947c93b59", "old_mode": 33188, "old_path": "pkg/compiler/lib/src/ssa/codegen.dart", "new_id": "9a2384129351c50149206311f3ee6067674977b7", "new_mode": 33188, "new_path": "pkg/compiler/lib/src/ssa/codegen.dart" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "c2137910a3d58767deeaf7955b0d0214e1be592d", "new_mode": 33188, "new_path": "pkg/compiler/lib/src/ssa/logging.dart" }, { "type": "modify", "old_id": "432eb7819688d94bc83ed155e427bd76eee5711d", "old_mode": 33188, "old_path": "pkg/compiler/lib/src/ssa/nodes.dart", "new_id": "568ae0b2701109e99108ae64ba484808f055648e", "new_mode": 33188, "new_path": "pkg/compiler/lib/src/ssa/nodes.dart" }, { "type": "modify", "old_id": "f245b5c9bf8ce44a6ba9bd7adbc21288ed5b798d", "old_mode": 33188, "old_path": "pkg/compiler/lib/src/ssa/optimize.dart", "new_id": "72a69eb5931a5a4452163fd178d29e276421ca6d", "new_mode": 33188, "new_path": "pkg/compiler/lib/src/ssa/optimize.dart" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "57aeba2dcea0c89ee98dac2fc6cfb0e0c451826d", "new_mode": 33188, "new_path": "pkg/compiler/lib/src/util/features.dart" }, { "type": "modify", "old_id": "b2bcb10851a132a1054f3069b2be13b5e3736fc5", "old_mode": 33188, "old_path": "pkg/compiler/lib/src/world.dart", "new_id": "0ed86957facefaac6faddcb33b94a1c497143a40", "new_mode": 33188, "new_path": "pkg/compiler/lib/src/world.dart" }, { "type": "modify", "old_id": "8ce572d1de0dfe47bf64a17822754d106c368e79", "old_mode": 33188, "old_path": "tests/compiler/dart2js/analyses/analysis_helper.dart", "new_id": "9e1560eb935543867b30cf339b2f8bd8a2df1ee8", "new_mode": 33188, "new_path": "tests/compiler/dart2js/analyses/analysis_helper.dart" }, { "type": "modify", "old_id": "7f837eb42fd8de4070c5ec00c41cd35f34b3bf90", "old_mode": 33188, "old_path": "tests/compiler/dart2js/analyses/dart2js_allowed.json", "new_id": "cb3e8297b38571e51e3617372f716ae79dba4f9b", "new_mode": 33188, "new_path": "tests/compiler/dart2js/analyses/dart2js_allowed.json" }, { "type": "modify", "old_id": "3cc81e2f2546eb552b67293f154c1870266bb57b", "old_mode": 33188, "old_path": "tests/compiler/dart2js/closure/closure_test.dart", "new_id": "566f192324019b57bf6e3543a2b18fba7d06d289", "new_mode": 33188, "new_path": "tests/compiler/dart2js/closure/closure_test.dart" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "c0145199871be76158b690083e2408abf6226fb4", "new_mode": 33188, "new_path": "tests/compiler/dart2js/codegen/model_data/dynamic_get.dart" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "ac96348ba83e775611a6ada27bef7ca6d8d7425f", "new_mode": 33188, "new_path": "tests/compiler/dart2js/codegen/model_data/dynamic_set.dart" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "e51540a1e0dfada6bfa6e39b683e590bd1faced1", "new_mode": 33188, "new_path": "tests/compiler/dart2js/codegen/model_test.dart" }, { "type": "modify", "old_id": "099c508715dfcc7f45b935e23b4fea7777a5e86d", "old_mode": 33188, "old_path": "tests/compiler/dart2js/deferred_loading/deferred_loading_test.dart", "new_id": "ac0d87e6bbbccf517978a26b000d4f897733e250", "new_mode": 33188, "new_path": "tests/compiler/dart2js/deferred_loading/deferred_loading_test.dart" }, { "type": "modify", "old_id": "73f4299c8e418e1f18b50c1dcccc04ba8349882b", "old_mode": 33188, "old_path": "tests/compiler/dart2js/equivalence/id_equivalence.dart", "new_id": "4d7654175e67f75fa445e180aa5661c5b22e00ab", "new_mode": 33188, "new_path": "tests/compiler/dart2js/equivalence/id_equivalence.dart" }, { "type": "modify", "old_id": "5762f41c13499838b58c84fcfd47daf04813d2c0", "old_mode": 33188, "old_path": "tests/compiler/dart2js/equivalence/id_equivalence_helper.dart", "new_id": "b046038fc44a93eafaedf484cac781e97346aba9", "new_mode": 33188, "new_path": "tests/compiler/dart2js/equivalence/id_equivalence_helper.dart" }, { "type": "modify", "old_id": "ab3ecff06b6c727a94a87f8b8670cb18dd8836b5", "old_mode": 33188, "old_path": "tests/compiler/dart2js/helpers/program_lookup.dart", "new_id": "e01108d3e9c648e1a9d73fc07ae32544a43c49e5", "new_mode": 33188, "new_path": "tests/compiler/dart2js/helpers/program_lookup.dart" }, { "type": "modify", "old_id": "7098aef4dcd62be02bf83b309e37f33dee716b37", "old_mode": 33188, "old_path": "tests/compiler/dart2js/impact/data/async.dart", "new_id": "24ab850db0069776d1623bd113db880bac7a615d", "new_mode": 33188, "new_path": "tests/compiler/dart2js/impact/data/async.dart" }, { "type": "modify", "old_id": "c5a6cb9627a8cc28893efa3504aee3d691db928a", "old_mode": 33188, "old_path": "tests/compiler/dart2js/impact/impact_test.dart", "new_id": "abef8a2b044833317965324931d92c752aa107e7", "new_mode": 33188, "new_path": "tests/compiler/dart2js/impact/impact_test.dart" }, { "type": "modify", "old_id": "cbcd56c2cbe049902eaf500eb9f6ff89af75e41b", "old_mode": 33188, "old_path": "tests/compiler/dart2js/inference/callers_test.dart", "new_id": "5a6a7196da821860d0b74893118d0019a7ca5d65", "new_mode": 33188, "new_path": "tests/compiler/dart2js/inference/callers_test.dart" }, { "type": "modify", "old_id": "4f3d3e9a1efef73f6a12716caf2794ba7192310e", "old_mode": 33188, "old_path": "tests/compiler/dart2js/inference/inference_data_test.dart", "new_id": "c0a964f21912d287d7fe662aefcd00f8c6cf3d2d", "new_mode": 33188, "new_path": "tests/compiler/dart2js/inference/inference_data_test.dart" }, { "type": "modify", "old_id": "37feb43891d68389526fec6c5682d9091b282379", "old_mode": 33188, "old_path": "tests/compiler/dart2js/inference/inference_test_helper.dart", "new_id": "5b5eb7f223c2cc1fac460dbdbd18d4d4b018ce6f", "new_mode": 33188, "new_path": "tests/compiler/dart2js/inference/inference_test_helper.dart" }, { "type": "modify", "old_id": "4b046629922a0aecbc9bfd5131c6d106a9ae5efb", "old_mode": 33188, "old_path": "tests/compiler/dart2js/inference/side_effects_test.dart", "new_id": "0e2e5cb93dc21054a332c8ed4f195fbd3c2c85c5", "new_mode": 33188, "new_path": "tests/compiler/dart2js/inference/side_effects_test.dart" }, { "type": "modify", "old_id": "b71d909cbc4b91c713bb23bc0b4b5eb887d01efb", "old_mode": 33188, "old_path": "tests/compiler/dart2js/inlining/inlining_test.dart", "new_id": "c6a8b920df52a2b0e145525a5f2bd58410abc682", "new_mode": 33188, "new_path": "tests/compiler/dart2js/inlining/inlining_test.dart" }, { "type": "modify", "old_id": "ee33c6ccaf5a6dab5f62da03874761318243f0fa", "old_mode": 33188, "old_path": "tests/compiler/dart2js/jumps/jump_test.dart", "new_id": "d06c5334f45c8567e33d094e00aefdb4d66b1bfd", "new_mode": 33188, "new_path": "tests/compiler/dart2js/jumps/jump_test.dart" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "e200302855a66e40ee6549781bd077daba9e3568", "new_mode": 33188, "new_path": "tests/compiler/dart2js/optimization/data/field_get.dart" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "953fe07a55aacc5f50209b7d97f573d890d370fc", "new_mode": 33188, "new_path": "tests/compiler/dart2js/optimization/data/field_set.dart" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "a5394b1ff82e0ccb1ed9beba033e123f0adf0f4f", "new_mode": 33188, "new_path": "tests/compiler/dart2js/optimization/data/finalized_type_variable.dart" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "0f2d0132c198090b376d711869f92a14a475ebc2", "new_mode": 33188, "new_path": "tests/compiler/dart2js/optimization/optimization_test.dart" }, { "type": "modify", "old_id": "ba12ff15c28c387fd8329bd9cb47f982dc85d768", "old_mode": 33188, "old_path": "tests/compiler/dart2js/rti/rti_emission_test.dart", "new_id": "fbabb7a735953756c5af5e0c3f39f7b7c7bfbf76", "new_mode": 33188, "new_path": "tests/compiler/dart2js/rti/rti_emission_test.dart" }, { "type": "modify", "old_id": "29bbaa1c01e9eea30707ae2837d688b9f1d373ae", "old_mode": 33188, "old_path": "tests/compiler/dart2js/rti/rti_need_test_helper.dart", "new_id": "1d201a186a3ad57cd8d80c99181fe414bacb53ed", "new_mode": 33188, "new_path": "tests/compiler/dart2js/rti/rti_need_test_helper.dart" }, { "type": "modify", "old_id": "bdc61ddb6f1d752ff25ea4611412323d1eeb17b7", "old_mode": 33188, "old_path": "tests/compiler/dart2js/static_type/static_type_test.dart", "new_id": "9ab49949098a7da1ad9b1461f5cbbbe270147c56", "new_mode": 33188, "new_path": "tests/compiler/dart2js/static_type/static_type_test.dart" } ] }