)]}'
{
  "commit": "e067bf7815e94a59c18e42fb90d1663ae5c53c86",
  "tree": "31248949dcd1ec321aae6bd389b57133a2438643",
  "parents": [
    "5d552a1f2ee118d9b7b00cd362574a46e8d00a52"
  ],
  "author": {
    "name": "Danny Tuppeny",
    "email": "danny@tuppeny.com",
    "time": "Mon Apr 15 17:36:20 2024 +0000"
  },
  "committer": {
    "name": "Commit Queue",
    "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Mon Apr 15 17:36:20 2024 +0000"
  },
  "message": "[analysis_server] Improve handling of const keywords for color picker\n\nThere were some inconsistencies with insertion of \"const\" keywords when selecting colors from the color picker (eg. https://github.com/Dart-Code/Dart-Code/issues/5068).\n\nSome of this was because some tests were testing different their own ranges that didn\u0027t match the ones the server would have provided (which meant the replacements were different).\n\nThis updates the tests to ensure all tests are using ranges that the server would have produced, changes to ensure any existing const keywords are included in the color expression (so if in future we allowed selecting named colours, existing const constructor keywords would be correctly removed) and fixes up some places where we didn\u0027t actually produce Colors (assigning top-level color variables in an initializer and constant patterns) but had tests assuming we did (which failed with the new checks).\n\nFixes https://github.com/Dart-Code/Dart-Code/issues/5068\n\nChange-Id: Id8814a426df4cbc350febabd11c963447c4b0e73\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/362801\nReviewed-by: Samuel Rawlins \u003csrawlins@google.com\u003e\nReviewed-by: Brian Wilkerson \u003cbrianwilkerson@google.com\u003e\nCommit-Queue: Brian Wilkerson \u003cbrianwilkerson@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "28f33958c3eaaaf3482dc1b388752999a21ebf1b",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/lib/src/computer/computer_color.dart",
      "new_id": "ad3c9d240cbbfd1868fbc292abc8c2e6fcc35f58",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/lib/src/computer/computer_color.dart"
    },
    {
      "type": "modify",
      "old_id": "60d4df40a833f2aa79ab82566139cc54554034a9",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/lib/src/lsp/handlers/handler_document_color_presentation.dart",
      "new_id": "40e34bdc6c0ea773e08bcc536975d28d7bef47c9",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/lib/src/lsp/handlers/handler_document_color_presentation.dart"
    },
    {
      "type": "modify",
      "old_id": "10df88c612ba8053d7d888e0b4ca672eedd69009",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/test/lsp/document_color_test.dart",
      "new_id": "49bb83d74b9ddb95dbe541f8a84a8f63d2b033ec",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/test/lsp/document_color_test.dart"
    },
    {
      "type": "modify",
      "old_id": "4a91634178df1b3109c1518a76090f704eb6b193",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/test/src/computer/color_computer_test.dart",
      "new_id": "845357938bee4a2ab92c69e01676441ee14dd831",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/test/src/computer/color_computer_test.dart"
    }
  ]
}