| commit | e0112afc705f232f1261fe8cc80cf468eb4ac45f | [log] [tgz] |
|---|---|---|
| author | Sigmund Cherem <sigmund@google.com> | Fri Oct 27 02:02:29 2023 +0000 |
| committer | Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Oct 27 02:02:29 2023 +0000 |
| tree | 668129093f04e3792d178dfc69001afb16398b65 | |
| parent | c439c97b80d6b0d1556e394bd12053864bad45d2 [diff] |
[web] delete notification_permission_test. This test provides very little value. It requests the notification permissions and waits for an answer. What's happening is that the test launches a prompt and then waiting for a user to click on the browser dialog to accept or reject the request. On the bots, this is consistently timing out in chrome and safari. Turns out this issue was [identified][1] 5 years ago and the test was marked as Timeout in the status files for that reason (dart2js) or skipped (DDC). Back then there were discussions about whether we could make chrome automatically accept or reject the request, but there was no traction on that. If we thought this test was providing value, we could explore whether there is a way to make bots automatically accept/reject the prompt by saving some preferences on the test machines. That said, I'm honestly not seeing much value here. For that reason, I'm inclined to delete the test instead. Other reasons to delete mentioned in the review: * this API may require a secure context, but our test runner doesn't default to use https yet * this API requires a [user gesture in FF][2] [1]: https://github.com/dart-lang/sdk/issues/32002 [2]: https://developer.mozilla.org/en-US/docs/Web/API/Notification/requestPermission_static Change-Id: Ib8d372b2ebfb5859a0a9bc82d50a14ad8badeab1 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/332320 Reviewed-by: Srujan Gaddam <srujzs@google.com> Commit-Queue: Sigmund Cherem <sigmund@google.com>
Dart is:
Optimized for UI: Develop with a programming language specialized around the needs of user interface creation.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app.
Fast on all platforms: Compile to ARM & x64 machine code for mobile, desktop, and backend. Or compile to JavaScript for the web.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.