tree 8d742e1022eea608a340af8e4d173f8a5ac64cab
parent 5333f30e1e32e0c851aaf85e3d8f998921a728c0
author Jens Johansen <jensj@google.com> 1728564076 +0000
committer Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> 1728564076 +0000

[CFE] Fix leak testing after kernels ast.dart was split into parts

The weekly bot this week finished in half the time, but was green.
Turns out the splitting of ast.dart into parts made the actual leak
testing not work because `Library` no longer existed in `ast.dart` (but
rather in `src/ast/libraries.dart`).

This CL:
1) Fixes the issue by also looking up the libraries uri (which is still
   `ast.dart`.
2) Adds an option for requiring to find instances of some things it
   looks for (e.g. `Library` in kernel) and throw if it doesn't. This
   would have made the weekly bot turn red (fail) instead of being green
  (saying that everything was fine) when really it wasn't.
3) Adds a test that is run on the try bots that will exercise the leak
   finding - and throw if it doesn't find `Library` in kernel.

Change-Id: Ie69bfbd188eb870fdc1e340a341c1271187ef110
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/389162
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>