tree 31642eb2dc1199c705254a92bc68f7e94da90890
parent 700ba716cd1f462f7fe664f71943d2f13fc6242e
author Johnni Winther <johnniwinther@google.com> 1614772688 +0000
committer commit-bot@chromium.org <commit-bot@chromium.org> 1614772688 +0000

[vm] Make async transform resilient in context of invalid type and never type of iterables

The CFE can invoke transformations despite having compile-time errors.
The async transform was crashing the compiler if it hits for-in
iterables that have an invalid type or never type.

In case of an invalid type, the program has a compile-time error and
won't be able to run propertly. So we'll replace the entire for-in with
an invalid expression statement if the iterable is an invalid
expression.

In case of a never type, the program should compile fine, which this CL
also fixes.

This makes the newly added tests no longer result in DartkCrash but
rather in a compile-time error (invalid expression) or runtime-error
(never type).

Closes https://github.com/dart-lang/sdk/issues/45014

Change-Id: Ic50f68400b67b57dd4a2c0a125b08f0f3e0d8dd6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/188463
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>