| commit | 781ea1be70d08e0fc676de201eb80bf085b26c09 | [log] [tgz] |
|---|---|---|
| author | Alexander Markov <alexmarkov@google.com> | Fri Oct 19 18:01:34 2018 +0000 |
| committer | commit-bot@chromium.org <commit-bot@chromium.org> | Fri Oct 19 18:01:34 2018 +0000 |
| tree | 0329edb35ee28fc0331e41829d853eb0809ec738 | |
| parent | c70666a3a3a5e0f63675a0bc3a383bfddc14e408 [diff] |
[vm/interpreter] Fix interpreter frame recognition in stack walking, v2 When GC is visiting pointers, it scans mutator thread even if it is not active. It could happen if a thread has (temporarily) exitted isolate. In such case, stack frame iteration would not find interpreter and would not recognize interpreter frames. An attempt to visit interpreter frame as non-interpreter causes crashes/assertions. The fix is to move interpreter from Isolate to Thread. This way interpreter is available for stack walking even if thread doesn't have isolate. This is the re-land of https://dart-review.googlesource.com/c/sdk/+/80760 with the fix for precompiler failures. Change-Id: I1fa054d43b86aa49c48490d0951b876b7c7218d8 Reviewed-on: https://dart-review.googlesource.com/c/80782 Auto-Submit: Alexander Markov <alexmarkov@google.com> Reviewed-by: Régis Crelier <regis@google.com> Commit-Queue: Régis Crelier <regis@google.com>
Dart is an open-source, scalable programming language, with robust libraries and runtimes, for building web, server, and mobile apps.
Visit the dartlang.org to learn more about the language, tools, getting started, and more.
Browse pub.dartlang.org for more packages and libraries contributed by the community and the Dart team.
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.